From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 952AEC4363A for ; Thu, 8 Oct 2020 13:31:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30A0A20754 for ; Thu, 8 Oct 2020 13:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729885AbgJHNbW (ORCPT ); Thu, 8 Oct 2020 09:31:22 -0400 Received: from mga17.intel.com ([192.55.52.151]:12082 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728969AbgJHNbV (ORCPT ); Thu, 8 Oct 2020 09:31:21 -0400 IronPort-SDR: 6NqxCrgQyj0ACTMO22MoiAXMFUVjKbp2KjS40bFRWwO0cP1MgxNO5CvLBVKESbLR8/T2Gh320y OH4R02Koe3ew== X-IronPort-AV: E=McAfee;i="6000,8403,9767"; a="145198616" X-IronPort-AV: E=Sophos;i="5.77,350,1596524400"; d="scan'208";a="145198616" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 06:31:20 -0700 IronPort-SDR: EDWXFozQHFQugMLk+t2v3OyALx6ntuphaaBF0B3QTsIyGXiDKUwLoWCds50m5lGqyVlFEZQU9B zBsNczW2IK+A== X-IronPort-AV: E=Sophos;i="5.77,350,1596524400"; d="scan'208";a="528494501" Received: from kweisner-mobl.amr.corp.intel.com (HELO [10.212.230.16]) ([10.212.230.16]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 06:31:18 -0700 Subject: Re: [PATCH v2 1/6] Add ancillary bus support To: Parav Pandit , "Ertman, David M" , Leon Romanovsky Cc: "alsa-devel@alsa-project.org" , "parav@mellanox.com" , "tiwai@suse.de" , "netdev@vger.kernel.org" , "ranjani.sridharan@linux.intel.com" , "fred.oh@linux.intel.com" , "linux-rdma@vger.kernel.org" , "dledford@redhat.com" , "broonie@kernel.org" , Jason Gunthorpe , "gregkh@linuxfoundation.org" , "kuba@kernel.org" , "Williams, Dan J" , "Saleem, Shiraz" , "davem@davemloft.net" , "Patil, Kiran" References: <20201005182446.977325-1-david.m.ertman@intel.com> <20201005182446.977325-2-david.m.ertman@intel.com> <20201006071821.GI1874917@unreal> <20201006170241.GM1874917@unreal> <20201007192610.GD3964015@unreal> From: Pierre-Louis Bossart Message-ID: <1e2a38ac-e259-f955-07ad-602431ad354b@linux.intel.com> Date: Thu, 8 Oct 2020 08:29:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org >>>>> But ... since the init() function is performing both device_init and >>>>> device_add - it should probably be called ancillary_device_register, >>>>> and we are back to a single exported API for both register and >>>>> unregister. >>>> >>>> Kind reminder that we introduced the two functions to allow the >>>> caller to know if it needed to free memory when initialize() fails, >>>> and it didn't need to free memory when add() failed since >>>> put_device() takes care of it. If you have a single init() function >>>> it's impossible to know which behavior to select on error. >>>> >>>> I also have a case with SoundWire where it's nice to first >>>> initialize, then set some data and then add. >>>> >>> >>> The flow as outlined by Parav above does an initialize as the first >>> step, so every error path out of the function has to do a >>> put_device(), so you would never need to manually free the memory in >> the setup function. >>> It would be freed in the release call. >> >> err = ancillary_device_initialize(); >> if (err) >> return ret; >> >> where is the put_device() here? if the release function does any sort of >> kfree, then you'd need to do it manually in this case. > Since device_initialize() failed, put_device() cannot be done here. > So yes, pseudo code should have shown, > if (err) { > kfree(adev); > return err; > } This doesn't work if the adev is part of a larger structure allocated by the parent, which is pretty much the intent to extent the basic bus and pass additional information which can be accessed with container_of(). Only the parent can do the kfree() explicitly in that case. If the parent relies on devm_kzalloc, this also can make the .release callback with no memory free required at all. See e.g. the code I cooked for the transition of SoundWire away from platform devices at https://github.com/thesofproject/linux/pull/2484/commits/d0540ae3744f3a748d49c5fe61469d82ed816981#diff-ac8eb3d3951c024f52b1d463b5317f70R305 The allocation is done on an 'ldev' which contains 'adev'. I really don't seen how an ancillary_device_register() could model the different ways to allocate memory, for maximum flexibility across different domains it seems more relevant to keep the initialize() and add() APIs separate. I will accept the argument that this puts more responsibility on the parent, but it also provides more flexibility to the parent. If we go with the suggested solution above, that already prevents SoundWire from using this bus. Not so good.