From: Alexei Starovoitov <ast@fb.com>
To: "Wangnan (F)" <wangnan0@huawei.com>,
"David S . Miller" <davem@davemloft.net>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, <netdev@vger.kernel.org>,
<kernel-team@fb.com>
Subject: Re: [PATCH net-next 4/6] tools/lib/bpf: expose bpf_program__set_type()
Date: Thu, 30 Mar 2017 19:37:41 -0700 [thread overview]
Message-ID: <1e3156bf-7334-53fe-1069-7d7bd9dc09fb@fb.com> (raw)
In-Reply-To: <b4ebf55a-d509-f4b8-8d71-c5dfc31f9c9d@huawei.com>
On 3/30/17 7:33 PM, Wangnan (F) wrote:
>> +void bpf_program__set_type(struct bpf_program *prog, enum
>> bpf_prog_type type);
>>
>
> This makes libbpf.h depend on uapi/linux/bpf.h (because of enum
> bpf_prog_type), which is not always available.
>
> What about defining another enum inside libbpf.h?
how about just including bpf.h? or making it 'int' instead of enum?
next prev parent reply other threads:[~2017-03-31 2:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 1:31 [PATCH net-next 0/6] bpf: program testing framework Alexei Starovoitov
2017-03-31 1:31 ` [PATCH net-next 1/6] bpf: introduce BPF_PROG_TEST_RUN command Alexei Starovoitov
2017-03-31 2:53 ` Wangnan (F)
2017-03-31 2:57 ` Alexei Starovoitov
2017-03-31 3:12 ` Wangnan (F)
2017-03-31 3:24 ` Alexei Starovoitov
2017-03-31 3:37 ` Wangnan (F)
2017-03-31 1:31 ` [PATCH net-next 2/6] tools/lib/bpf: add support for " Alexei Starovoitov
2017-03-31 3:15 ` Wangnan (F)
2017-03-31 3:26 ` Alexei Starovoitov
2017-03-31 1:31 ` [PATCH net-next 3/6] selftests/bpf: add a test for overlapping packet range checks Alexei Starovoitov
2017-03-31 1:31 ` [PATCH net-next 4/6] tools/lib/bpf: expose bpf_program__set_type() Alexei Starovoitov
2017-03-31 2:33 ` Wangnan (F)
2017-03-31 2:37 ` Alexei Starovoitov [this message]
2017-03-31 2:48 ` Wangnan (F)
2017-03-31 2:56 ` Alexei Starovoitov
2017-03-31 1:31 ` [PATCH net-next 5/6] selftests/bpf: add a test for basic XDP functionality Alexei Starovoitov
2017-03-31 1:31 ` [PATCH net-next 6/6] selftests/bpf: add l4 load balancer test based on sched_cls Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e3156bf-7334-53fe-1069-7d7bd9dc09fb@fb.com \
--to=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).