From: Daniel Borkmann <daniel@iogearbox.net>
To: Quentin Monnet <quentin.monnet@netronome.com>,
alexei.starovoitov@gmail.com, netdev@vger.kernel.org
Cc: oss-drivers@netronome.com, jakub.kicinski@netronome.com
Subject: Re: [PATCH bpf-next v2 00/14] nfp: bpf: relocations, verifier log, signed jumps and other updates
Date: Wed, 10 Jan 2018 15:05:32 +0100 [thread overview]
Message-ID: <1e3fe91e-1bbb-a4bd-c73c-d9be00e4b897@iogearbox.net> (raw)
In-Reply-To: <1515587167-1959-1-git-send-email-quentin.monnet@netronome.com>
On 01/10/2018 01:25 PM, Quentin Monnet wrote:
> Jakub says:
>
> Hi!
>
> This series starts with a fix to Jesper's recent work, somehow I forgot
> about control rings during review. Second patch is cleaning up a vNIC
> header, in kdoc we should not use @ for #define constants. Aligning of
> the top of the stack as well as bottom (last bytes will be unused) helps
> the performance. We should check offload datapath's max MTU when program
> is loaded and we can allow TC hw offload flag to be changed freely while
> XDP offload is active.
>
> Next group of patches adds more fully featured relocation support. Due
> to limited amount of code space we only load the image to NIC's memory
> when program is attached. Since we can't predict which programs are
> loaded later, we should translate as if image was to be loaded at offset
> zero and only apply relocations at load time. Many more advanced features
> (eg. tail class, subprograms, dynamic allocation of program space and
> sharing it between ports) will depend on this.
>
> Nic adds support for signed comparison instructions.
>
> Quentin makes use of the verifier log in our driver, the verifier print
> function (verbose()) has to be renamed and exported.
>
> v2:
> - replace #define by function aliasing for verbose() in patch 13
That's better, thanks for addressing the alias as well. Series applied
to bpf-next, thanks guys!
prev parent reply other threads:[~2018-01-10 14:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 12:25 [PATCH bpf-next v2 00/14] nfp: bpf: relocations, verifier log, signed jumps and other updates Quentin Monnet
2018-01-10 12:25 ` [PATCH bpf-next v2 01/14] nfp: don't try to register XDP rxq structures on control queues Quentin Monnet
2018-01-10 12:25 ` [PATCH bpf-next v2 02/14] nfp: fix incumbent kdoc warnings Quentin Monnet
2018-01-10 12:25 ` [PATCH bpf-next v2 03/14] nfp: bpf: round up the size of the stack Quentin Monnet
2018-01-10 12:25 ` [PATCH bpf-next v2 04/14] nfp: bpf: don't allow changing MTU above BPF offload limit when active Quentin Monnet
2018-01-10 12:25 ` [PATCH bpf-next v2 05/14] nfp: bpf: allow disabling TC offloads when XDP active Quentin Monnet
2018-01-10 12:25 ` [PATCH bpf-next v2 06/14] nfp: bpf: move jump resolution to jit.c Quentin Monnet
2018-01-10 12:26 ` [PATCH bpf-next v2 07/14] nfp: bpf: add helpers for modifying branch addresses Quentin Monnet
2018-01-10 12:26 ` [PATCH bpf-next v2 08/14] nfp: bpf: relocate jump targets just before the load Quentin Monnet
2018-01-10 12:26 ` [PATCH bpf-next v2 09/14] nfp: bpf: don't depend on high order allocations for program image Quentin Monnet
2018-01-10 12:26 ` [PATCH bpf-next v2 10/14] nfp: bpf: use a large constant in unresolved branches Quentin Monnet
2018-01-10 12:26 ` [PATCH bpf-next v2 11/14] nfp: hand over to BPF offload app at coarser granularity Quentin Monnet
2018-01-10 12:26 ` [PATCH bpf-next v2 12/14] nfp: bpf: add signed jump insns Quentin Monnet
2018-01-10 12:26 ` [PATCH bpf-next v2 13/14] bpf: export function to write into verifier log buffer Quentin Monnet
2018-01-10 12:26 ` [PATCH bpf-next v2 14/14] nfp: bpf: reuse verifier log for debug messages Quentin Monnet
2018-01-10 14:05 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e3fe91e-1bbb-a4bd-c73c-d9be00e4b897@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=quentin.monnet@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).