From: Florian Fainelli <f.fainelli@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
"Russell King (Oracle)" <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Ioana Ciornei" <ciorneiioana@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Ioana Ciornei" <ioana.ciornei@nxp.com>,
"Alexandru Ardelean" <alexandru.ardelean@analog.com>,
"Andre Edich" <andre.edich@microchip.com>,
"Antoine Tenart" <atenart@kernel.org>,
"Baruch Siach" <baruch@tkos.co.il>,
"Christophe Leroy" <christophe.leroy@c-s.fr>,
"Divya Koppera" <Divya.Koppera@microchip.com>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Kavya Sree Kotagiri" <kavyasree.kotagiri@microchip.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Marco Felsch" <m.felsch@pengutronix.de>,
"Marek Vasut" <marex@denx.de>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Mathias Kresin" <dev@kresin.me>,
"Maxim Kochetkov" <fido_max@inbox.ru>,
"Michael Walle" <michael@walle.cc>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Nisar Sayed" <Nisar.Sayed@microchip.com>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Philippe Schenker" <philippe.schenker@toradex.com>,
"Willy Liu" <willy.liu@realtek.com>,
"Yuiko Oshino" <yuiko.oshino@microchip.com>
Subject: Re: [PATCH] net: phy: Don't disable irqs on shutdown if WoL is enabled
Date: Tue, 8 Aug 2023 14:59:41 -0700 [thread overview]
Message-ID: <1e438a02-6964-ce65-5584-e8ea57a694bb@gmail.com> (raw)
In-Reply-To: <20230808145325.343c5098@kernel.org>
On 8/8/23 14:53, Jakub Kicinski wrote:
> On Fri, 4 Aug 2023 09:17:57 +0200 Uwe Kleine-König wrote:
>> Most PHYs signal WoL using an interrupt. So disabling interrupts breaks
>> WoL at least on PHYs covered by the marvell driver. So skip disabling
>> irqs on shutdown if WoL is enabled.
>>
>> While at it also explain the motivation that irqs are disabled at all.
>>
>> Fixes: e2f016cf7751 ("net: phy: add a shutdown procedure")
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> What do we do with this one? It sounded like Russell was leaning
> towards a revert?
Yes, though I believe this will create a different kind of regression
for what Iona was addressing initially. Then it becomes a choice of
which regression do we consider to be the worst to handle until
something better comes up.
Russell what are your thoughts?
--
Florian
next prev parent reply other threads:[~2023-08-08 21:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 7:17 [PATCH] net: phy: Don't disable irqs on shutdown if WoL is enabled Uwe Kleine-König
2023-08-08 21:53 ` Jakub Kicinski
2023-08-08 21:59 ` Florian Fainelli [this message]
2023-08-08 22:56 ` Russell King (Oracle)
2023-08-09 14:21 ` Ioana Ciornei
2023-08-09 14:29 ` Russell King (Oracle)
2023-08-09 15:44 ` Ioana Ciornei
2023-08-09 16:01 ` Russell King (Oracle)
2023-08-09 16:21 ` Andrew Lunn
2023-08-09 17:04 ` Florian Fainelli
2023-08-09 19:15 ` Russell King (Oracle)
2023-08-10 11:01 ` Ioana Ciornei
2023-08-09 13:58 ` Vladimir Oltean
2023-08-09 15:35 ` Florian Fainelli
2023-08-10 6:32 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e438a02-6964-ce65-5584-e8ea57a694bb@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Divya.Koppera@microchip.com \
--cc=Nisar.Sayed@microchip.com \
--cc=alexandru.ardelean@analog.com \
--cc=andre.edich@microchip.com \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=baruch@tkos.co.il \
--cc=christophe.leroy@c-s.fr \
--cc=ciorneiioana@gmail.com \
--cc=dev@kresin.me \
--cc=fido_max@inbox.ru \
--cc=hauke@hauke-m.de \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jbrunet@baylibre.com \
--cc=kavyasree.kotagiri@microchip.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.felsch@pengutronix.de \
--cc=marex@denx.de \
--cc=martin.blumenstingl@googlemail.com \
--cc=michael@walle.cc \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=philippe.schenker@toradex.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=willy.liu@realtek.com \
--cc=yuiko.oshino@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).