Re: [PATCH net-next] net: page_pool: rename page_pool_is_last_ref()

[Alexander Lobakin <aleksander.lobakin@intel.com>]

From: Jakub Kicinski <kuba@kernel.org>
Date: Fri, 13 Dec 2024 07:37:59 -0800

> page_pool_is_last_ref() releases a reference while the name,
> to me at least, suggests it just checks if the refcount is 1.
> The semantics of the function are the same as those of
> atomic_dec_and_test() and refcount_dec_and_test(), so just
> use the _and_test() suffix.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Makes sense to me, I think I had issues in the past with references
while developing stuff, as I thought this function doesn't modify
anything :D

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

> ---
> Hopefully this doesn't conflict with anyone's work, I've been
> deferring sending this rename forever because I always look
> at it while reviewing an in-flight series and then I'm worried
> it will conflict.

Thanks,
Olek