From: David Ahern <dsahern@gmail.com>
To: Xin Long <lucien.xin@gmail.com>, network dev <netdev@vger.kernel.org>
Cc: davem@davemloft.net, simon.horman@netronome.com,
jakub.kicinski@netronome.com
Subject: Re: [PATCH net-next] net: remove the unnecessary strict_start_type in some policies
Date: Thu, 21 Nov 2019 12:47:01 -0700 [thread overview]
Message-ID: <1e546f81-559a-b03d-5acf-b935fcea0268@gmail.com> (raw)
In-Reply-To: <bcd455a3339a42f32dd2970d5495740ea1ee142d.1574330918.git.lucien.xin@gmail.com>
On 11/21/19 3:08 AM, Xin Long wrote:
> ct_policy and mpls_policy are parsed with nla_parse_nested(), which
> does NL_VALIDATE_STRICT validation, strict_start_type is not needed
> to set as it is actually trying to make some attributes parsed with
> NL_VALIDATE_STRICT.
>
> This patch is to remove it, and do the same on rtm_nh_policy which
> is parsed by nlmsg_parse().
>
> Suggested-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> net/ipv4/nexthop.c | 1 -
> net/sched/act_ct.c | 1 -
> net/sched/act_mpls.c | 1 -
> 3 files changed, 3 deletions(-)
>
>
Reviewed-by: David Ahern <dsahern@gmail.com>
prev parent reply other threads:[~2019-11-21 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 10:08 [PATCH net-next] net: remove the unnecessary strict_start_type in some policies Xin Long
2019-11-21 18:51 ` Jakub Kicinski
2019-11-21 19:46 ` David Miller
2019-11-21 19:47 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e546f81-559a-b03d-5acf-b935fcea0268@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).