From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 372B5C432C0 for ; Thu, 21 Nov 2019 19:47:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F00D20672 for ; Thu, 21 Nov 2019 19:47:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y7kGxZGW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726992AbfKUTrH (ORCPT ); Thu, 21 Nov 2019 14:47:07 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:45954 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726563AbfKUTrG (ORCPT ); Thu, 21 Nov 2019 14:47:06 -0500 Received: by mail-qt1-f193.google.com with SMTP id 30so5014018qtz.12 for ; Thu, 21 Nov 2019 11:47:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1wrZnmz4pWQby46tFwFeUMbdVaMTLA4eaqr+Zqe1q/Q=; b=Y7kGxZGWDY0TtFAamaeKOw/IYXYW4L+db6U1ag7YFEkEnsZ5lvzX/xgapgXmC4+JlU HifKDcFYyhCx9aj4V2DYYvOPVFHOLvKtDIzdY8KGbUlTtcbJtU4W8+bWPzu8elVDoaHB MD1NE9QrQ6LXc6usnJjwLd97DCSHnaF7DTtybbXQa6v+8+UiAlUML3X2/sqs0+TfqdAi bTlDk7gon+tnfLz/pGB3Rb+vheXIcPqqIEfn/EJgV6fKT6TWngMhCKjGI8dzAwS4OLGO UoqbTq0JTYTcgmL5dJVncjFpsjaEdu/aUiphdbViWn+SEkpiVCB9fPPHYp8YhRWCdBIU 8Z/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1wrZnmz4pWQby46tFwFeUMbdVaMTLA4eaqr+Zqe1q/Q=; b=ppAU5PN02r5Gz6QEB8/dbzRuEHh0qkIRrd7zsUDregj/lUwSgk6IFON2R9pdCciMI0 z0JvaRfYbc2ggtUkNRg5eTVfljf+zDrijwlunVajnAFV5XA1z/7ZioN8lWbJ+1aaaINg u1aa9osvK9MF/6vrwyyClfrl+4M9vW7SU738EcKexICF7Gt6oxphGS2s7TXmA0rsr5N/ kZBAFQEaKkijKs7INQkSY9kclCbiOLZAdmZpN1UKqaosMII8qO2nEIWzVE5gZCcm4/ko MLm+DH1ZpYBuU+g0QAvdRLGS3vbxOu9KR3fwhrWp0/Ks9EQqhdE/3yDKg7/0+2/ridDm hvWQ== X-Gm-Message-State: APjAAAX5TD3bdyz61N6zERFqhHtvG4FBIGnCYqqzzT4sh0XcffmMZj0B uc52SCIXsRSuwpzCNs68TUA= X-Google-Smtp-Source: APXvYqzfA8Z1KLashA7uNh3vYrWL2XQATutTcKNBX2MbmLCoge928vMJSjuUhV2pxlM0XQVFIz1NCA== X-Received: by 2002:ac8:18af:: with SMTP id s44mr10303707qtj.1.1574365624382; Thu, 21 Nov 2019 11:47:04 -0800 (PST) Received: from dahern-DO-MB.local ([2601:282:800:fd80:b9b1:601f:b338:feda]) by smtp.googlemail.com with ESMTPSA id x39sm2126661qth.92.2019.11.21.11.47.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2019 11:47:03 -0800 (PST) Subject: Re: [PATCH net-next] net: remove the unnecessary strict_start_type in some policies To: Xin Long , network dev Cc: davem@davemloft.net, simon.horman@netronome.com, jakub.kicinski@netronome.com References: From: David Ahern Message-ID: <1e546f81-559a-b03d-5acf-b935fcea0268@gmail.com> Date: Thu, 21 Nov 2019 12:47:01 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/21/19 3:08 AM, Xin Long wrote: > ct_policy and mpls_policy are parsed with nla_parse_nested(), which > does NL_VALIDATE_STRICT validation, strict_start_type is not needed > to set as it is actually trying to make some attributes parsed with > NL_VALIDATE_STRICT. > > This patch is to remove it, and do the same on rtm_nh_policy which > is parsed by nlmsg_parse(). > > Suggested-by: Jakub Kicinski > Signed-off-by: Xin Long > --- > net/ipv4/nexthop.c | 1 - > net/sched/act_ct.c | 1 - > net/sched/act_mpls.c | 1 - > 3 files changed, 3 deletions(-) > > Reviewed-by: David Ahern