Netdev List
 help / color / mirror / Atom feed
From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Dave Butler <david.butler@appgate.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"edumazet@kernel.org" <edumazet@kernel.org>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"emil.s.tantilov@intel.com" <emil.s.tantilov@intel.com>,
	"luoxuanqiang@kylinos.cn" <luoxuanqiang@kylinos.cn>,
	"bryan.fraschetti@canonical.com" <bryan.fraschetti@canonical.com>,
	"tristan@talencesecurity.com" <tristan@talencesecurity.com>,
	"tomasz.lichwala@linux.intel.com"
	<tomasz.lichwala@linux.intel.com>,
	"horms@kernel.org" <horms@kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Jacob Keller <jacob.e.keller@intel.com>,
	"Aleksandr Loktionov" <aleksandr.loktionov@intel.com>
Subject: Re: [PATCH net 6/6] iavf: cap advertised max_pkt_size at the single-buffer HW limit
Date: Wed, 30 Sep 2026 13:32:44 +0200	[thread overview]
Message-ID: <1e749682-a51d-4e07-9db8-c8f7cb4f439a@intel.com> (raw)
In-Reply-To: <DS7PR05MB73201A15AD9E0795156F88B18B8C2@DS7PR05MB7320.namprd05.prod.outlook.com>

From: Dave Butler <david.butler@appgate.com>
Date: Tue, 29 Sep 2026 20:32:53 +0000

>>> +     max_frame = min(max_frame, LIBIE_MAX_RX_BUF_LEN);
>> Shouldn't we cap it to 9728 instead?
> 
> No objection.  To be clear, LIBIE_MAX_RX_BUF_LEN is 9728, so it's
> the same value.

Oops sorry, I did misread. I thought for some reason that you now limit
it to (4096 - hr/tr overhead) >_<

Acked-by: Alexander Lobakin <aleksander.lobakin@intel.com>

> 
> Before 5fa4caff59f2 the cap was IAVF_MAX_RXBUFFER (9728, "largest size for
> single descriptor"), and that same commit replaced it with LIBIE_MAX_RX_BUF_LEN
> (9728U, "The largest size for a single descriptor as per HW").
> 
> That said, I'm happy to do whatever.  Just let me know your preference.
> 
> Intended recipient is public
> The information contained in this electronic mail is confidential information intended only for the use of the individual(s) or entity(s) named. If the reader of the message is not the addressee (or authorized to receive for the addressee), you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please immediately notify the sender by reply e-mail and/or by telephone and destroy the original message.

Thanks,
Olek

  reply	other threads:[~2026-09-30 11:32 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 23:04 [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-09-28 (idpf, ice, iavf) Tony Nguyen
2026-09-28 23:04 ` [PATCH net 1/6] idpf: fix possible race on remove during a reset Tony Nguyen
2026-09-30  0:58   ` netdev-bot+sashiko
2026-10-01 23:40     ` Tantilov, Emil S
2026-09-28 23:04 ` [PATCH net 2/6] ice: fix use-after-free in dynamic port cleanup Tony Nguyen
2026-09-28 23:04 ` [PATCH net 3/6] ice: Restore Ordered MMIO Writes for Tx Doorbells Tony Nguyen
2026-09-30  0:58   ` netdev-bot+sashiko
2026-10-01 16:35     ` Tony Nguyen
2026-09-28 23:04 ` [PATCH net 4/6] ice: fix metadata_dst refcount handling on representor teardown Tony Nguyen
2026-09-28 23:04 ` [PATCH net 5/6] iavf: fix VF stats not updating due to PTP command preemption Tony Nguyen
2026-09-30  0:58   ` netdev-bot+sashiko
2026-09-30 15:07     ` Tomasz Lichwala
2026-09-28 23:04 ` [PATCH net 6/6] iavf: cap advertised max_pkt_size at the single-buffer HW limit Tony Nguyen
2026-09-29 16:18   ` Alexander Lobakin
2026-09-29 20:32     ` Dave Butler
2026-09-30 11:32       ` Alexander Lobakin [this message]
2026-09-30  0:58   ` netdev-bot+sashiko
2026-09-30  6:02     ` Dave Butler
     [not found]       ` <IA3PR05MB22078430E404FAD12912A706298B892@IA3PR05MB220784.namprd05.prod.outlook.com>
     [not found]         ` <CANm61jc37jivo=XmRwN8ic8PNJFXZK+6Gsw5VRy=b-oZKpMsMA@mail.gmail.com>
2026-10-02 21:09           ` Fw: " David Butler
2026-09-28 23:10 ` [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-09-28 (idpf, ice, iavf) netdev-bot+sinfo
2026-09-29  1:41   ` Dave Butler
     [not found]     ` <IA3PR05MB22078467309FA5DFF33EF712488B892@IA3PR05MB220784.namprd05.prod.outlook.com>
2026-10-02 21:21       ` Fw: " David Butler
2026-09-29 17:16   ` Tantilov, Emil S
2026-09-30 15:06   ` Tomasz Lichwala
2026-10-01 23:47 ` Tony Nguyen
2026-10-02 20:39   ` Jakub Kicinski
     [not found]     ` <IA3PR05MB220784D3846E12367B0CA1D3738B892@IA3PR05MB220784.namprd05.prod.outlook.com>
     [not found]       ` <CANm61jco98RoBmBAtbnjRZCPwqS0Vt6SqXjYAEUwSD4-bWLuZA@mail.gmail.com>
2026-10-02 21:06         ` Fw: " David Butler
2026-10-02 20:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e749682-a51d-4e07-9db8-c8f7cb4f439a@intel.com \
    --to=aleksander.lobakin@intel.com \
    --cc=aleksandr.loktionov@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=bryan.fraschetti@canonical.com \
    --cc=davem@davemloft.net \
    --cc=david.butler@appgate.com \
    --cc=edumazet@kernel.org \
    --cc=emil.s.tantilov@intel.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=luoxuanqiang@kylinos.cn \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=tomasz.lichwala@linux.intel.com \
    --cc=tristan@talencesecurity.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox