From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 840D8C00A89 for ; Mon, 2 Nov 2020 15:10:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 298AC2074B for ; Mon, 2 Nov 2020 15:10:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N0CYExff" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726366AbgKBPKe (ORCPT ); Mon, 2 Nov 2020 10:10:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726088AbgKBPKd (ORCPT ); Mon, 2 Nov 2020 10:10:33 -0500 Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0610C0617A6 for ; Mon, 2 Nov 2020 07:10:31 -0800 (PST) Received: by mail-il1-x144.google.com with SMTP id y17so13251053ilg.4 for ; Mon, 02 Nov 2020 07:10:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=H0XYAVKnEHF+vyMT1nf9jpk2juyymss8CccZfOgHI/M=; b=N0CYExffB1sGr5E4+JIqrsClSwBYsDCNH204ASOBZN6u4ymw1bO+sfgZvTOYIU2VAS j5xAtokFR7Ad0lfZwMuo4Z1i/yvcTICFuJlcqeWsBMVc83ty9IW10Bx3TEGHXrUWJGcU BBYCm39ObOXrdWIcJFZ0J7nch1dMYkasUP+nJM9Vyx22/EcqiuOTFn7gcHve4hYLoetn vChnLpeAJ3qHaegIgL23EvpEz0SN4PxrUtFUpKC4uvCZUWwcqk92SlyMDaAWgn6NA19k hJA8WUApxzjt8NBRdo4yPA4Z5Ekm9eyPzLY/1x2y0Pez3zCt/QF4Rpzg2obgO4uR9W5c mc/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=H0XYAVKnEHF+vyMT1nf9jpk2juyymss8CccZfOgHI/M=; b=c4XUJVdXDgnyzKdZTdxZsbV7v3MMhFIOl0PLxPSuSo2aKOy/ZJV8IgwUHkIpRTUUTx 8tIHBnSzIUay/RqrIbqLBMBIMYy5xKl8a1Ka5p8M+FtgNWPbMF1CJC9tsl9iWkT0EsvP f3aU9wc5IRU/zPF9nHd+29aTZ12jmhmVVkAavDI3uBqWdwQrKetO7cZFwqyCAfWAWCWe jp7Gq23CWeBLY+6L49TX32hO4w5hsqjoy9nxwp0WaNWrZS5HRKeritgQzKX8WCAdw7zu CQLQuKcPg3LSGUcEO78GJ1MbdGGCNZiGeJMSef6rNjEgQLLrAPknHHITgBrn/kAqc1Pc RQvg== X-Gm-Message-State: AOAM531Xcty7IsrLXZ5jO/JYZ1oRJLxoNne5Kvf0aCKYOhuCRV4EftCA yrnplLMWbSkSS0TKC7SPjQA= X-Google-Smtp-Source: ABdhPJzzuqQ4HHNWBYlYlhkxnwAYLhGvfy7Y7ogOjqQjuzFSzO6i71QL1bbX8nItTRpAmLpI/x0G+g== X-Received: by 2002:a92:a14f:: with SMTP id v76mr11355481ili.293.1604329831236; Mon, 02 Nov 2020 07:10:31 -0800 (PST) Received: from Davids-MacBook-Pro.local ([2601:282:803:7700:4ca9:ddcf:e3b:9c54]) by smtp.googlemail.com with ESMTPSA id c3sm12418824ila.47.2020.11.02.07.10.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Nov 2020 07:10:30 -0800 (PST) Subject: Re: [PATCH iproute2-next v2 03/11] lib: utils: Add print_on_off_bool() To: Leon Romanovsky Cc: Petr Machata , netdev@vger.kernel.org, stephen@networkplumber.org, john.fastabend@gmail.com, jiri@nvidia.com, idosch@nvidia.com, Jakub Kicinski , Roman Mashak References: <5ed9e2e7cdf9326e8f7ec80f33f0f11eafc3a425.1604059429.git.me@pmachata.org> <0f017fbd-b8f5-0ebe-0c16-0d441b1d4310@gmail.com> <87o8kihyy9.fsf@nvidia.com> <20201102063752.GE5429@unreal> From: David Ahern Message-ID: <1e77c615-5ad9-e999-8c68-874baddfecfd@gmail.com> Date: Mon, 2 Nov 2020 08:10:28 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201102063752.GE5429@unreal> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/1/20 11:37 PM, Leon Romanovsky wrote: > However I don't understand why print_on_off_bool() is implemented in > utils.c and not in lib/json_print.c that properly handles JSON context, > provide colorized output and doesn't require to supply FILE *fp. Good point, I missed that earlier.