From: Richard Gobert <richardbgobert@gmail.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
donald.hunter@gmail.com, andrew+netdev@lunn.ch,
dsahern@kernel.org, shuah@kernel.org, daniel@iogearbox.net,
jacob.e.keller@intel.com, razor@blackwall.org, petrm@nvidia.com,
menglong8.dong@gmail.com, martin.lau@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 5/5] selftests/net: add vxlan localbind selftest
Date: Wed, 13 Aug 2025 17:49:31 +0200 [thread overview]
Message-ID: <1e8ba3fa-81b6-4921-a02b-1d6da756ecec@gmail.com> (raw)
In-Reply-To: <aJx6pUrnRMnh0RAU@shredder>
Ido Schimmel wrote:
> On Tue, Aug 12, 2025 at 02:51:55PM +0200, Richard Gobert wrote:
>> Test to make sure the localbind netlink option works
>> in VXLAN interfaces.
>
> Thanks for adding a test. A few clerical comments:
>
> 1. Indentation is inconsistent. Please convert to 8 characters tabs.
>
> 2. netdev CI started running shellcheck. I don't think you can eliminate
> all the errors, but some can be easily fixed.
>
> 3. There's a blank line at the end of the file that should be removed.
I'll take a look. Thanks.
next prev parent reply other threads:[~2025-08-13 15:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 12:51 [PATCH net-next v5 0/5] net: add local address bind support to vxlan and geneve Richard Gobert
2025-08-12 12:51 ` [PATCH net-next v5 1/5] net: udp: add freebind option to udp_sock_create Richard Gobert
2025-08-13 9:25 ` Ido Schimmel
2025-08-13 15:10 ` Richard Gobert
2025-08-12 12:51 ` [PATCH net-next v5 2/5] net: vxlan: add netlink option to bind vxlan sockets to local addresses Richard Gobert
2025-08-13 6:28 ` Kuniyuki Iwashima
2025-08-13 15:46 ` Richard Gobert
2025-08-13 16:04 ` Ido Schimmel
2025-08-13 17:55 ` Kuniyuki Iwashima
2025-08-13 9:26 ` Ido Schimmel
2025-08-12 12:51 ` [PATCH net-next v5 3/5] net: vxlan: bind vxlan sockets to their local address if configured Richard Gobert
2025-08-13 7:07 ` Kuniyuki Iwashima
2025-08-13 15:41 ` Richard Gobert
2025-08-13 9:26 ` Ido Schimmel
2025-08-13 15:18 ` Richard Gobert
2025-08-12 12:51 ` [PATCH net-next v5 4/5] net: geneve: enable binding geneve sockets to local addresses Richard Gobert
2025-08-12 12:51 ` [PATCH net-next v5 5/5] selftests/net: add vxlan localbind selftest Richard Gobert
2025-08-13 11:44 ` Ido Schimmel
2025-08-13 15:49 ` Richard Gobert [this message]
2025-08-13 14:34 ` Jakub Kicinski
2025-08-13 15:52 ` Richard Gobert
2025-08-13 9:25 ` [PATCH net-next v5 0/5] net: add local address bind support to vxlan and geneve Ido Schimmel
2025-08-13 15:29 ` Richard Gobert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e8ba3fa-81b6-4921-a02b-1d6da756ecec@gmail.com \
--to=richardbgobert@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).