From: Eric Joyner <eric.joyner@amd.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Brett Creeley <brett.creeley@amd.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"Nikhil P . Rao" <nikhil.rao@amd.com>
Subject: Re: [PATCH net-next] ionic: Add .get_fec_stats ethtool handler
Date: Fri, 14 Aug 2026 13:21:41 -0700 [thread overview]
Message-ID: <1ea0dd7d-2a61-4029-8e03-4751d53126bb@amd.com> (raw)
In-Reply-To: <20260814120520.11e24409@kernel.org>
On 8/14/2026 12:05 PM, Jakub Kicinski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On Fri, 31 Jul 2026 14:40:21 -0700 Eric Joyner wrote:
>> Reports FEC statistics totals and an 802.3ck FEC histogram. Per-lane counts
>> currently aren't supported, and the only expected histogram format from
>> firmware is the one with 16 bins from RS(544,514) FEC.
>
> To be clear this patch is now too old for us to process, you need to
> repost. Before you do - double check the 'shiko, it has things to say:
> https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260731214021.15279-1-eric.joyner@amd.com
Ok, I'll address the Sashiko review comments and resubmit.
But a couple questions: the Sashiko instance at this site looks like it's doing
more review than what the Sashiko bot at sashiko.dev does; should I be checking
this site for Sashiko reviews instead? As well, I don't think the upstream
Sashiko repository has support for cross-reviewing; is this site running on a
custom version or some early unreleased code?
- Eric
next prev parent reply other threads:[~2026-08-14 20:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 21:40 [PATCH net-next] ionic: Add .get_fec_stats ethtool handler Eric Joyner
2026-08-04 10:27 ` Vadim Fedorenko
2026-08-14 4:42 ` Eric Joyner
2026-08-14 12:14 ` vadim.fedorenko
2026-08-14 19:05 ` Jakub Kicinski
2026-08-14 20:21 ` Eric Joyner [this message]
2026-08-14 20:41 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ea0dd7d-2a61-4029-8e03-4751d53126bb@amd.com \
--to=eric.joyner@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikhil.rao@amd.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox