From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH bpf-next v2 2/2] samples/bpf: Add xdp_sample_pkts example
Date: Tue, 5 Jun 2018 01:43:19 +0200
Message-ID: <1ef5fdfd-3225-89e2-c6b5-d3fe2573d655@iogearbox.net>
References: <152813003609.3465.618891361534945522.stgit@alrua-kau>
 <152813003614.3465.11049830599815911223.stgit@alrua-kau>
 <20180604153205.72678576@cakuba.netronome.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: netdev@vger.kernel.org
To: Jakub Kicinski <kubakici@wp.pl>,
        =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vu?= =?UTF-8?Q?sen?=
        <toke@toke.dk>
Return-path: <netdev-owner@vger.kernel.org>
Received: from www62.your-server.de ([213.133.104.62]:59653 "EHLO
        www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751987AbeFDXnV (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 4 Jun 2018 19:43:21 -0400
In-Reply-To: <20180604153205.72678576@cakuba.netronome.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 06/05/2018 12:32 AM, Jakub Kicinski wrote:
> On Mon, 04 Jun 2018 18:33:56 +0200, Toke Høiland-Jørgensen wrote:
>> +	if (load_bpf_file(filename)) {
> 
> Would you mind using libbpf instead of bpf_load.o?  I converted some
> samples in be5bca44aa6b ("samples: bpf: convert some XDP samples from
> bpf_load to libbpf"), it's pretty straight forward.  Maybe we can kill
> bpf_load.o one day :)

Agreed, we should only be using libbpf going forward.