Netdev List
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Bhumika Goyal <bhumirks@gmail.com>,
	julia.lawall@lip6.fr, netdev@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ravb: make mdiobb_ops const
Date: Tue, 22 Aug 2017 15:03:37 +0300	[thread overview]
Message-ID: <1f074a7c-0d3a-e569-4400-c50d967e550c@cogentembedded.com> (raw)
In-Reply-To: <1503389282-17369-1-git-send-email-bhumirks@gmail.com>

Hello!

On 08/22/2017 11:08 AM, Bhumika Goyal wrote:

> Make these const as they are only stored in a const field of a
> mdiobb_ctrl structure.

> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>   drivers/net/ethernet/renesas/ravb_main.c | 2 +-
>   drivers/net/ethernet/renesas/sh_eth.c    | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

    If you're fixing both Renesas drivers at once, your subject should be 
"renesas: make mdiobb_ops const". With that fixed, you have my:

Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

MBR, Sergei

  reply	other threads:[~2017-08-22 12:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-22  8:08 [PATCH] ravb: make mdiobb_ops const Bhumika Goyal
2017-08-22 12:03 ` Sergei Shtylyov [this message]
2017-08-22 12:06   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f074a7c-0d3a-e569-4400-c50d967e550c@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=bhumirks@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox