From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [PATCH bpf-next v4 3/5] selftests/bpf: test_sockmap, timing improvements Date: Fri, 1 Jun 2018 07:11:56 -0700 Message-ID: <1f1895d0-0620-f6df-c3c3-033360bd310e@gmail.com> References: <20180531044240.796-1-bhole_prashant_q7@lab.ntt.co.jp> <20180531044240.796-4-bhole_prashant_q7@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "David S . Miller" , Shuah Khan , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org To: Prashant Bhole , Alexei Starovoitov , Daniel Borkmann Return-path: Received: from mail-io0-f194.google.com ([209.85.223.194]:39745 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbeFAOMJ (ORCPT ); Fri, 1 Jun 2018 10:12:09 -0400 In-Reply-To: <20180531044240.796-4-bhole_prashant_q7@lab.ntt.co.jp> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/30/2018 09:42 PM, Prashant Bhole wrote: > Currently 10us delay is too low for many tests to succeed. It needs to > be increased. Also, many corked tests are expected to hit rx timeout > irrespective of timeout value. > > - This patch sets 1000usec timeout value for corked tests because less > than that causes broken-pipe error in tx thread. Also sets 1 second > timeout for all other tests because less than that results in RX > timeout > - tests with apply=1 and higher number of iterations were taking lot > of time. This patch reduces test run time by reducing iterations. > > real 0m12.968s > user 0m0.219s > sys 0m14.337s > > Fixes: a18fda1a62c3 ("bpf: reduce runtime of test_sockmap tests") > Signed-off-by: Prashant Bhole > --- OK seems more reasonable to me. We could probably even go lower on some of the 'rate' values here if needed (512->128). Acked-by: John Fastabend