From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "Linus Walleij" <linusw@kernel.org>,
"Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
"Ahmad Fatoum" <a.fatoum@pengutronix.de>,
"Alvin Šipraga" <alvin.sipraga@analog.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: dsa: realtek: rtl8365mb: add EEE support
Date: Thu, 3 Sep 2026 14:24:30 +0200 [thread overview]
Message-ID: <1f2253f9-3368-4033-a091-ce424c08af89@lunn.ch> (raw)
In-Reply-To: <20260903092211.2922058-3-o.rempel@pengutronix.de>
On Thu, Sep 03, 2026 at 11:22:11AM +0200, Oleksij Rempel wrote:
> Add EEE support on the integrated-PHY ports, controllable per port via
> ethtool.
>
> The integrated PHYs have no MMD registers; their EEE registers live in the
> switch's OCP space. phylib accesses EEE as MMD registers, so add
> phy_{read,write}_c45 realtek_ops that map those MMD accesses onto their OCP
> addresses, wired as the user MII bus C45 handlers when the chip provides
> them (rtl8366rb etc. unaffected).
>
> The hardware manages LPI on its own, so advertise EEE to phylink with
> no-op mac_{en,dis}able_tx_lpi callbacks. The LPI timer is a single global
> per-speed register, so .set_mac_eee rejects the per-port TX LPI knobs
> rather than silently ignoring them.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
prev parent reply other threads:[~2026-09-03 12:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 9:22 [PATCH net-next v2 0/2] net: dsa: realtek: EEE support for RTL8365MB-VC Oleksij Rempel
2026-09-03 9:22 ` [PATCH net-next v2 1/2] net: phy: realtek: use C45 for RTL8365MB-VC internal PHY MMD access Oleksij Rempel
2026-09-03 9:22 ` [PATCH net-next v2 2/2] net: dsa: realtek: rtl8365mb: add EEE support Oleksij Rempel
2026-09-03 12:24 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f2253f9-3368-4033-a091-ce424c08af89@lunn.ch \
--to=andrew@lunn.ch \
--cc=a.fatoum@pengutronix.de \
--cc=alvin.sipraga@analog.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox