From mboxrd@z Thu Jan  1 00:00:00 1970
From: Serhey Popovych <serhe.popovych@gmail.com>
Subject: Re: [PATCH iproute2-next v2 0/9] With this series I propose to make
 print_linkinfo_brief() static in
Date: Wed, 14 Feb 2018 23:35:44 +0200
Message-ID: <1f8351fe-f812-12ab-1de7-ee9f4ee40eb1@gmail.com>
References: <1518644024-12684-1-git-send-email-serhe.popovych@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="vAMv2SP7o04Y7yqcC8hQj3l4kFMF2aYJj"
Cc: dsahern@gmail.com
To: netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-lf0-f68.google.com ([209.85.215.68]:44290 "EHLO
        mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1030501AbeBNVf6 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 14 Feb 2018 16:35:58 -0500
Received: by mail-lf0-f68.google.com with SMTP id c188so15498345lfc.11
        for <netdev@vger.kernel.org>; Wed, 14 Feb 2018 13:35:57 -0800 (PST)
In-Reply-To: <1518644024-12684-1-git-send-email-serhe.popovych@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--vAMv2SP7o04Y7yqcC8hQj3l4kFMF2aYJj
Content-Type: multipart/mixed; boundary="MAx5cpZsJErtQDC7O3Coxqa8XuTsu843Z";
 protected-headers="v1"
From: Serhey Popovych <serhe.popovych@gmail.com>
To: netdev@vger.kernel.org
Cc: dsahern@gmail.com
Message-ID: <1f8351fe-f812-12ab-1de7-ee9f4ee40eb1@gmail.com>
Subject: Re: [PATCH iproute2-next v2 0/9] With this series I propose to make
 print_linkinfo_brief() static in
References: <1518644024-12684-1-git-send-email-serhe.popovych@gmail.com>
In-Reply-To: <1518644024-12684-1-git-send-email-serhe.popovych@gmail.com>

--MAx5cpZsJErtQDC7O3Coxqa8XuTsu843Z
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Please ignore this series: wrong subject.

> Changes presented with this series tested using following script:
>=20
> \#!/bin/bash
>=20
> iproute2_dir=3D"$1"
> iface=3D'eth0.2'
>=20
> pushd "$iproute2_dir" &>/dev/null
>=20
> for i in new old; do
> 	DIR=3D"/tmp/$i"
> 	mkdir -p "$DIR"
>=20
> 	ln -snf ip.$i ip/ip
>=20
> 	# normal
> 	ip/ip link show                  >"$DIR/ip-link-show"
> 	ip/ip -4 addr show               >"$DIR/ip-4-addr-show"
> 	ip/ip -6 addr show               >"$DIR/ip-6-addr-show"
> 	ip/ip addr show dev "$iface"     >"$DIR/ip-addr-show-$iface"
>=20
> 	# brief
> 	ip/ip -br link show              >"$DIR/ip-br-link-show"
> 	ip/ip -br -4 addr show           >"$DIR/ip-br-4-addr-show"
> 	ip/ip -br -6 addr show           >"$DIR/ip-br-6-addr-show"
> 	ip/ip -br addr show dev "$iface" >"$DIR/ip-br-addr-show-$iface"
> done
> rm -f ip/ip
>=20
> diff -urN /tmp/{old,new} |sed -n -Ee'/^(-{3}|\+{3})[[:space:]]+/!p'
> rc=3D$?
>=20
> popd &>/dev/null
> exit $rc
>=20
> Expected results : <no output>
> Actual results   : <no output>
>=20
> Although test coverage is far from ideal in my opinion it covers most
> important aspects of the changes presented by the series.
>=20
> All this work is done in prepare of iplink_get() enhancements to suppor=
t
> attribute parse that finally will be used to simplify ip/tunnel
> RTM_GETLINK code.
>=20
> As always reviews, comments, suggestions and criticism is welcome.
>=20
> v2
>   Rebased to current iproute2-next/master. No changes.
>=20
> Thanks,
> Serhii
>=20
> Serhey Popovych (9):
>   ipaddress: Abstract IFA_LABEL matching code
>   ipaddress: ll_map: Replace ll_idx_n2a() with ll_index_to_name()
>   utils: Reimplement ll_idx_n2a() and introduce ll_idx_a2n()
>   ipaddress: Improve print_linkinfo()
>   ipaddress: Simplify print_linkinfo_brief() and it's usage
>   lib: Correct object file dependencies
>   utils: Introduce and use get_ifname_rta()
>   utils: Introduce and use print_name_and_link() to print name@link
>   ipaddress: Make print_linkinfo_brief() static
>=20
>  bridge/link.c    |   21 ++---
>  include/ll_map.h |    4 +-
>  include/utils.h  |    5 ++
>  ip/ip_common.h   |    2 -
>  ip/ipaddress.c   |  224 ++++++++++++++--------------------------------=
--------
>  ip/iplink.c      |    5 +-
>  lib/Makefile     |    4 +-
>  lib/ll_map.c     |   31 +++++---
>  lib/utils.c      |   68 +++++++++++++++++
>  9 files changed, 162 insertions(+), 202 deletions(-)
>=20



--MAx5cpZsJErtQDC7O3Coxqa8XuTsu843Z--

--vAMv2SP7o04Y7yqcC8hQj3l4kFMF2aYJj
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBAgAGBQJahKu6AAoJEBTawMmQ61bB1/kIAL95GVsfH0pER2wQdfzr1/4z
+Bgq1A0xSf5E5i5KIoWcDBTtY2cuiEqTNmoWGVnmhVCyGvA3dh3jULIlbjyFJJjf
TJ2QDOudrobsKjbk+UY3cjCrFYhX18tdOpoT+DiKBZd/BrMYX0aHQzT1CM7eBp/T
BnU69P+2Oi3o2q9Z8TY8GWrE0yAjEX2tbCV4adSgtOx9yMQM/zhTQoAMkqyXE2J5
he6YN8IOGLo5mqXDnL5lbkr+4ae4t8U67RiwXm+WfFbpY6wJ+YQwgXSveOziXcRR
DoOHFI2V7PPVmUOCFyWDMYOu3eKbAq1eic47r/yR6eg/6lP5Mh/OgwPyWyaZDvU=
=gUAo
-----END PGP SIGNATURE-----

--vAMv2SP7o04Y7yqcC8hQj3l4kFMF2aYJj--