From: Colin Ian King <colin.king@canonical.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Solomon Peachy <pizza@shaftnet.org>,
"David S . Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cw1200: fix indentation issues
Date: Thu, 17 Jan 2019 14:56:23 +0000 [thread overview]
Message-ID: <1fa8b078-1db9-d109-e8e5-f05dc0e48fd6@canonical.com> (raw)
In-Reply-To: <87sgxrpc6q.fsf@kamboji.qca.qualcomm.com>
On 17/01/2019 14:54, Kalle Valo wrote:
> Colin King <colin.king@canonical.com> writes:
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There are two lines that have indentation issues, fix these.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/net/wireless/st/cw1200/fwio.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/st/cw1200/fwio.c b/drivers/net/wireless/st/cw1200/fwio.c
>> index 30e7646d04af..b7881232499c 100644
>> --- a/drivers/net/wireless/st/cw1200/fwio.c
>> +++ b/drivers/net/wireless/st/cw1200/fwio.c
>> @@ -465,8 +465,8 @@ int cw1200_load_firmware(struct cw1200_common *priv)
>>
>> if (!(val32 & ST90TDS_CONFIG_ACCESS_MODE_BIT)) {
>> pr_err("Device is already in QUEUE mode!\n");
>> - ret = -EINVAL;
>> - goto out;
>> + ret = -EINVAL;
>> + goto out;
>
> Just out of curiosity, how do you find these?
>
smatch, grep for "warn: inconsistent indenting"
Colin
next prev parent reply other threads:[~2019-01-17 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 14:36 [PATCH] cw1200: fix indentation issues Colin King
2019-01-17 14:54 ` Kalle Valo
2019-01-17 14:56 ` Colin Ian King [this message]
2019-02-01 12:19 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fa8b078-1db9-d109-e8e5-f05dc0e48fd6@canonical.com \
--to=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pizza@shaftnet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox