From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH net-next v2 1/6] net: bridge: Publish bridge accessor functions Date: Fri, 27 Apr 2018 18:38:18 +0300 Message-ID: <1faecfc8-bf75-6ab4-cb7d-44ef27d75bf6@cumulusnetworks.com> References: <20180427151111.22099-1-idosch@mellanox.com> <20180427151111.22099-2-idosch@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, jiri@mellanox.com, petrm@mellanox.com, stephen@networkplumber.org, mlxsw@mellanox.com To: Ido Schimmel , netdev@vger.kernel.org, bridge@lists.linux-foundation.org Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:40280 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932788AbeD0PiV (ORCPT ); Fri, 27 Apr 2018 11:38:21 -0400 Received: by mail-wm0-f67.google.com with SMTP id j5so3669091wme.5 for ; Fri, 27 Apr 2018 08:38:21 -0700 (PDT) In-Reply-To: <20180427151111.22099-2-idosch@mellanox.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 27/04/18 18:11, Ido Schimmel wrote: > From: Petr Machata > > Add a couple new functions to allow querying FDB and vlan settings of a > bridge. > > Signed-off-by: Petr Machata > Signed-off-by: Ido Schimmel > --- > include/linux/if_bridge.h | 28 ++++++++++++++++++++++++++++ > net/bridge/br_fdb.c | 22 ++++++++++++++++++++++ > net/bridge/br_private.h | 11 +++++++++++ > net/bridge/br_vlan.c | 39 +++++++++++++++++++++++++++++++++++++++ > 4 files changed, 100 insertions(+) > Thanks! This looks good to me although the new exported helpers could've taken both bridge or port and return the result. Usually when adding a port-only functions we name them with nbp_ prefix instead of br_. Anyway this can be done later since the API is internal, Signed-off-by: Nikolay Aleksandrov