From: Josua Mayer <josua@solid-run.com>
To: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Gregory Clement <gregory.clement@bootlin.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH RFC 2/7] net: Add helpers for netdev LEDs
Date: Fri, 22 Mar 2024 18:33:28 +0000 [thread overview]
Message-ID: <1fc37850-e74a-47a8-9c74-2fa08b4eae9e@solid-run.com> (raw)
In-Reply-To: <20240317-v6-8-0-net-next-mv88e6xxx-leds-v4-v1-2-80a4e6c6293e@lunn.ch>
Am 17.03.24 um 22:45 schrieb Andrew Lunn:
> Add a set of helpers for parsing the standard device tree properties
> for LEDs are part of an ethernet device, and registering them with the
> LED subsystem. This code can be used by any sort of netdev driver, DSA
> switch or pure switchdev switch driver.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> ...
>
> +struct netdev_leds_ops {
> + int (*brightness_set)(struct net_device *ndev, u8 led,
> + enum led_brightness brightness);
> + int (*blink_set)(struct net_device *ndev, u8 led,
> + unsigned long *delay_on, unsigned long *delay_off);
> + int (*hw_control_is_supported)(struct net_device *ndev, u8 led,
> + unsigned long flags);
> + int (*hw_control_set)(struct net_device *ndev, u8 led,
> + unsigned long flags);
> + int (*hw_control_get)(struct net_device *ndev, u8 led,
> + unsigned long *flags);
> +};
I noticed phy.h calls the "flags" argument "rules" instead,
perhaps that is more suitable.
next prev parent reply other threads:[~2024-03-22 18:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 21:45 [PATCH RFC 0/7] net: Add generic support for netdev LEDs Andrew Lunn
2024-03-17 21:45 ` [PATCH RFC 1/7] dsa: move call to driver port_setup after creation of netdev Andrew Lunn
2024-03-17 21:45 ` [PATCH RFC 2/7] net: Add helpers for netdev LEDs Andrew Lunn
2024-03-21 15:01 ` Jakub Kicinski
2024-03-21 15:35 ` Andrew Lunn
2024-03-21 15:43 ` Jakub Kicinski
2024-03-22 18:33 ` Josua Mayer [this message]
2024-03-22 18:56 ` Andrew Lunn
2024-03-17 21:45 ` [PATCH RFC 3/7] net: dsa: mv88e6xxx: Add helpers for 6352 LED blink and brightness Andrew Lunn
2024-03-17 21:45 ` [PATCH RFC 4/7] net: dsa: mv88e6xxx: Tie the low level LED functions to device ops Andrew Lunn
2024-03-17 21:45 ` [PATCH RFC 5/7] net: dsa: Add helpers to convert netdev to ds or port index Andrew Lunn
2024-03-17 21:45 ` [PATCH RFC 6/7] dsa: mv88e6xxx: Create port/netdev LEDs Andrew Lunn
2024-03-17 21:45 ` [PATCH RFC 7/7] arm: boot: dts: mvebu: linksys-mamba: Add Ethernet LEDs Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fc37850-e74a-47a8-9c74-2fa08b4eae9e@solid-run.com \
--to=josua@solid-run.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).