From: David Ahern <dsahern@gmail.com>
To: Quentin Monnet <quentin.monnet@netronome.com>,
dsahern@kernel.org, netdev@vger.kernel.org,
borkmann@iogearbox.net, ast@kernel.org
Cc: davem@davemloft.net
Subject: Re: [PATCH bpf-net] bpf: Change bpf_fib_lookup to return lookup status
Date: Tue, 19 Jun 2018 09:02:49 -0600 [thread overview]
Message-ID: <1fe738f0-3f96-fa0d-2169-165f9abc37f0@gmail.com> (raw)
In-Reply-To: <a856c7da-da18-9460-3eff-4d25ed6852ea@netronome.com>
On 6/19/18 3:36 AM, Quentin Monnet wrote:
> Since you are about to respin (I think?), could you please also fix the
> formatting in your change to the doc? The "BPF_FIB_LKUP_RET_" is not
> emphasized (and will even cause an error message when producing the man
> page, because of the trailing underscore that gets interpreted in RST),
> and the three cases for the return value are not formatted properly for
> the conversion.
>
> Something like the following would work:
>
> ---
> * Return
> * * < 0 if any input argument is invalid.
> * * 0 on success (packet is forwarded and nexthop neighbor exists).
> * * > 0: one of **BPF_FIB_LKUP_RET_** codes on FIB lookup response.
> ---
>
Will do. thanks for the review.
prev parent reply other threads:[~2018-06-19 15:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-17 15:18 [PATCH bpf-net] bpf: Change bpf_fib_lookup to return lookup status dsahern
2018-06-18 18:11 ` Martin KaFai Lau
2018-06-18 18:27 ` David Ahern
2018-06-18 20:55 ` Martin KaFai Lau
2018-06-18 21:35 ` David Ahern
2018-06-19 15:25 ` Martin KaFai Lau
2018-06-19 15:34 ` David Ahern
2018-06-19 16:36 ` Martin KaFai Lau
2018-06-19 20:16 ` David Ahern
2018-06-19 21:24 ` Martin KaFai Lau
2018-06-19 15:11 ` David Ahern
2018-06-19 9:36 ` Quentin Monnet
2018-06-19 15:02 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fe738f0-3f96-fa0d-2169-165f9abc37f0@gmail.com \
--to=dsahern@gmail.com \
--cc=ast@kernel.org \
--cc=borkmann@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quentin.monnet@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).