From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH bpf-net] bpf: Change bpf_fib_lookup to return lookup status Date: Tue, 19 Jun 2018 09:02:49 -0600 Message-ID: <1fe738f0-3f96-fa0d-2169-165f9abc37f0@gmail.com> References: <20180617151819.6824-1-dsahern@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net To: Quentin Monnet , dsahern@kernel.org, netdev@vger.kernel.org, borkmann@iogearbox.net, ast@kernel.org Return-path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:40487 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937365AbeFSPCw (ORCPT ); Tue, 19 Jun 2018 11:02:52 -0400 Received: by mail-pl0-f66.google.com with SMTP id t12-v6so11103051plo.7 for ; Tue, 19 Jun 2018 08:02:52 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 6/19/18 3:36 AM, Quentin Monnet wrote: > Since you are about to respin (I think?), could you please also fix the > formatting in your change to the doc? The "BPF_FIB_LKUP_RET_" is not > emphasized (and will even cause an error message when producing the man > page, because of the trailing underscore that gets interpreted in RST), > and the three cases for the return value are not formatted properly for > the conversion. > > Something like the following would work: > > --- > * Return > * * < 0 if any input argument is invalid. > * * 0 on success (packet is forwarded and nexthop neighbor exists). > * * > 0: one of **BPF_FIB_LKUP_RET_** codes on FIB lookup response. > --- > Will do. thanks for the review.