netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: bert hubert <ahu@ds9a.nl>
To: kuznet@ms2.inr.ac.ru
Cc: albertogli@telpin.COM.AR, netdev@oss.sgi.com, jdike@karaya.com
Subject: Re: Frozen machine with adding a tc filter
Date: Wed, 24 Jul 2002 00:11:42 +0200	[thread overview]
Message-ID: <20020723221142.GA15146@outpost.ds9a.nl> (raw)
In-Reply-To: <200207232156.BAA16799@sex.inr.ac.ru>

On Wed, Jul 24, 2002 at 01:56:22AM +0400, kuznet@ms2.inr.ac.ru wrote:
> Hello!
> 
> > However, with the commandlines specified, the classifier returns.. head,
> 
> This is strange. cbq_bind_filter() is supposed to return nil class,
> unless reference has deeper level.

These are the commandlines:

tc qdisc add dev eth0 handle 1:0 root cbq bandwidth 12500000bps avpkt 1000      
tc class add dev eth0 parent 1:0 classid 1:2 cbq bandwidth 12500000bps rate \
	10000bps allot 1500 avpkt 1000 maxburst 5 bounded                              
tc filter add dev eth0 parent 1:0 protocol ip prio 1 handle 1:0:0 u32 \
          divisor 1
tc filter add dev eth0 parent 1:0 protocol ip prio 1 u32 match u32 \             
	0xd5f4a8d2 0xffffffff at 16 classid 1:0  

In the last command, cbq_bind_filter is called with parent==0:

static unsigned long cbq_bind_filter(struct Qdisc *sch, unsigned long parent,
				     u32 classid)
{
	struct cbq_sched_data *q = (struct cbq_sched_data *)sch->data;
	struct cbq_class *p = (struct cbq_class*)parent;
	struct cbq_class *cl = cbq_class_lookup(q, classid);

	if (cl) {
		if (p && p->level <= cl->level)
			return 0;
		cl->filters++;
		return (unsigned long)cl;
	}
	return 0;
}

cl->level is in fact 1.


Regards,

bert

-- 
http://www.PowerDNS.com          Versatile DNS Software & Services
http://www.tk                              the dot in .tk
http://lartc.org           Linux Advanced Routing & Traffic Control HOWTO

  reply	other threads:[~2002-07-23 22:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-22  3:49 Frozen machine with adding a tc filter Alberto Bertogli
2002-07-22 20:46 ` kuznet
2002-07-22 21:21   ` bert hubert
2002-07-22 22:57     ` kuznet
2002-07-23 21:28       ` bert hubert
2002-07-23 21:56         ` kuznet
2002-07-23 22:11           ` bert hubert [this message]
2002-07-23 22:19             ` kuznet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020723221142.GA15146@outpost.ds9a.nl \
    --to=ahu@ds9a.nl \
    --cc=albertogli@telpin.COM.AR \
    --cc=jdike@karaya.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).