From: Andi Kleen <ak@suse.de>
To: Harald Welte <laforge@gnumonks.org>
Cc: David Miller <davem@redhat.com>,
netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix HIPQUAD macro in kernel.h
Date: Thu, 8 Aug 2002 13:41:13 +0200 [thread overview]
Message-ID: <20020808134113.A2552@wotan.suse.de> (raw)
In-Reply-To: <20020808133112.E11828@sunbeam.de.gnumonks.org>
On Thu, Aug 08, 2002 at 01:31:12PM +0200, Harald Welte wrote:
> Hi Dave!
>
> Below is a fix for the HIPQUAD macro in kernel.h. The macro is currently
> not endian-aware - it just assumes running on a little-endian machine.
>
> If you don't like the #ifdefs in kernel.h, the macros could be moved into
> include/linux/byteorder/.
>
> Please apply, thanks
That change is wrong. IP address should be always in network order (=BE)
while in kernel.
-Andi
next prev parent reply other threads:[~2002-08-08 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-08 11:31 [PATCH] fix HIPQUAD macro in kernel.h Harald Welte
2002-08-08 11:41 ` Andi Kleen [this message]
2002-08-08 12:06 ` Harald Welte
2002-08-08 14:48 ` David S. Miller
2002-08-08 14:58 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020808134113.A2552@wotan.suse.de \
--to=ak@suse.de \
--cc=davem@redhat.com \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).