From: Matthew Wilcox <willy@debian.org>
To: kuznet@ms2.inr.ac.ru
Cc: Matthew Wilcox <willy@debian.org>,
davem@redhat.com, jmorris@intercode.com.au, netdev@oss.sgi.com
Subject: Re: [PATCH] minor socket ioctl cleanup for 2.5.30
Date: Thu, 8 Aug 2002 18:17:17 +0100 [thread overview]
Message-ID: <20020808181717.P24631@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <200208081713.VAA02896@sex.inr.ac.ru>; from kuznet@ms2.inr.ac.ru on Thu, Aug 08, 2002 at 09:13:15PM +0400
On Thu, Aug 08, 2002 at 09:13:15PM +0400, kuznet@ms2.inr.ac.ru wrote:
> No, this is not true. This creepy ioctl is specific to TCP
> (well, x.25 also uses SIGURG), which use kill*(sk->proc, SIGURG) directly.
>
> Probably, it is better to move sk->proc to TCP private data,
> this ioctl to tcp_ioctl(). Or... find a way to get rid of this completely,
> not breaking compatibility with a few BSDish applications.
jamesm also has patches which remove sk->proc altogether and make TCP
use the normal fasync methods. this ioctl then does an f_setown and
most of the creepiness is gone. consider this patch a stepping-stone.
--
Revolutions do not require corporate support.
next prev parent reply other threads:[~2002-08-08 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-08 0:24 [PATCH] minor socket ioctl cleanup for 2.5.30 James Morris
2002-08-08 15:33 ` David S. Miller
2002-08-08 16:07 ` Matthew Wilcox
2002-08-08 17:13 ` kuznet
2002-08-08 17:17 ` Matthew Wilcox [this message]
2002-08-08 17:26 ` James Morris
2002-08-08 17:42 ` Matthew Wilcox
2002-08-08 17:46 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020808181717.P24631@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=davem@redhat.com \
--cc=jmorris@intercode.com.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).