netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@redhat.com>
To: kuznet@ms2.inr.ac.ru
Cc: netdev@oss.sgi.com
Subject: Re: [patch] bug prematurely setting nr_frags
Date: Tue, 13 Aug 2002 14:31:20 -0400	[thread overview]
Message-ID: <20020813143120.C12730@redhat.com> (raw)
In-Reply-To: <200208130406.IAA20038@sex.inr.ac.ru>; from kuznet@ms2.inr.ac.ru on Tue, Aug 13, 2002 at 08:06:13AM +0400

On Tue, Aug 13, 2002 at 08:06:13AM +0400, kuznet@ms2.inr.ac.ru wrote:
> Hello!
> 
> > Huh?  It's called from sock_alloc_send_skb, which is called from all 
> > over the stack.
> 
> It is used with data_len==0. The branch generating fragments is dead.

Ah, I see.  Care for a patch to remove it altogether then?  As for the 
bug, does anyone else see a place where nr_frags can be set without 
initializing a page pointer?  Otherwise it looks like a random memory 
corruption... what fun.

		-ben
-- 
"You will be reincarnated as a toad; and you will be much happier."

  reply	other threads:[~2002-08-13 18:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-09 20:14 [patch] bug prematurely setting nr_frags Benjamin LaHaise
2002-08-11 21:07 ` kuznet
2002-08-12 23:07   ` Benjamin LaHaise
2002-08-13  4:06     ` kuznet
2002-08-13 18:31       ` Benjamin LaHaise [this message]
2002-08-13 22:27         ` kuznet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020813143120.C12730@redhat.com \
    --to=bcrl@redhat.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).