From: "David S. Miller" <davem@redhat.com>
To: greearb@candelatech.com
Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Networking: send-to-self [link to non-broken patch this time]
Date: Wed, 18 Sep 2002 15:55:34 -0700 (PDT) [thread overview]
Message-ID: <20020918.155534.102954410.davem@redhat.com> (raw)
In-Reply-To: <3D8826BE.5090007@candelatech.com>
From: Ben Greear <greearb@candelatech.com>
Date: Wed, 18 Sep 2002 00:09:50 -0700
http://www.candelatech.com/sts_2.4.19.patch
I don't think I'll be applying this:
1) No tcp ipv6 bits
2) SIOC{S,G}ACCEPTLOCALADDRS added, but no 32-bit translation
code added to varions 64-bit/32-bit biarch port ioctl handling.
Also, no code added to the ioctl dispatch in the networking
so that devices could actually receive these requests.
3) Finally, it's just too damn ugly. If you have to ifdef it then
it really doesn't belong in the tree. Maybe if the device number
comparison logic changes existed via macros in tcp.h and thus
removing all the CONFIG_NET_SENDTOSELF ifdefs from tcp*.c code
it might be more palatable.
4) I haven't reviewed the ramifications of the route lookup changes,
that is Alexey's territory.
Sorry, these changes are pretty ugly right now.
next prev parent reply other threads:[~2002-09-18 22:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-18 6:47 [PATCH] Networking: send-to-self Ben Greear
2002-09-18 6:44 ` David S. Miller
2002-09-18 6:53 ` Ben Greear
2002-09-18 7:09 ` [PATCH] Networking: send-to-self [link to non-broken patch this time] Ben Greear
2002-09-18 22:55 ` David S. Miller [this message]
2002-09-18 23:20 ` Ben Greear
2002-09-19 1:28 ` David S. Miller
2002-09-19 2:07 ` Ben Greear
2002-09-19 2:01 ` David S. Miller
2002-09-19 3:04 ` Ben Greear
2002-09-27 1:00 ` [PATCH] Networking: send-to-self [link to non-broken patch this kuznet
2002-09-27 1:30 ` Ben Greear
2002-09-27 3:36 ` kuznet
2002-09-27 6:33 ` Ben Greear
2002-09-27 15:01 ` kuznet
2002-09-27 15:40 ` Ben Greear
2002-09-27 15:46 ` kuznet
2002-09-27 15:53 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020918.155534.102954410.davem@redhat.com \
--to=davem@redhat.com \
--cc=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).