From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: mbp@samba.org (Martin Pool)
Cc: davem@redhat.com, ak@muc.de, netdev@oss.sgi.com, Alan.Cox@linux.org
Subject: Re: FIN_WAIT1 / TCP_CORK / 2.2 -- reproducible bug and test case
Date: Thu, 19 Sep 2002 03:38:37 +0400 (MSD) [thread overview]
Message-ID: <200209182338.DAA00778@mops.inr.ac.ru> (raw)
In-Reply-To: <20020918020927.GB2285@samba.org> from "Martin Pool" at Sep 18, 2 12:09:29 pm
Hello!
> I can't reproduce it on 2.4.18 or .19. It looked to me like
> tcp_snd_test() and related stuff had been substantially rewritten.
No, tcp_snd_test() in 2.2 is backport and it is accurate.
Apparently, the problem remained in another place, which was not backported.
I think this is tcp_send_fin(). It is obscure and apparently incorrect
at least on corked sockets. I would kill all the dubious "if" after
/* Special case to avoid Nagle bogosity....
and replaced it with straight tcp_push_pending_frames() like it was
made in 2.4. Please, try.
Alexey
BTW your tcpdump contains less than 25% of packets. And all the interesting
piece is absent completely. :-)
next prev parent reply other threads:[~2002-09-18 23:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-18 2:03 FIN_WAIT1 / TCP_CORK / 2.2 -- reproducible bug and test case Martin Pool
2002-09-18 1:58 ` David S. Miller
2002-09-18 2:09 ` Martin Pool
2002-09-18 23:38 ` Alexey Kuznetsov [this message]
2002-09-26 5:47 ` Martin Pool
2002-09-26 13:09 ` kuznet
2002-09-26 20:46 ` David S. Miller
2002-09-30 9:59 ` Martin Pool
2002-09-30 10:32 ` David S. Miller
2002-09-30 12:23 ` Alan Cox
2002-10-03 3:30 ` James Morris
2002-10-03 3:54 ` Andi Kleen
2002-10-03 7:59 ` David S. Miller
2002-10-03 7:56 ` David S. Miller
2002-09-18 2:30 ` Martin Pool
-- strict thread matches above, loose matches on Subject: below --
2002-10-04 15:06 James Morris
2002-10-04 23:27 ` Martin Pool
2002-10-05 7:51 ` Martin Pool
2002-10-05 11:53 ` James Morris
2002-10-08 10:21 ` Martin Pool
2002-10-08 10:28 ` James Morris
2002-10-10 16:36 ` James Morris
2002-10-10 16:43 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200209182338.DAA00778@mops.inr.ac.ru \
--to=kuznet@ms2.inr.ac.ru \
--cc=Alan.Cox@linux.org \
--cc=ak@muc.de \
--cc=davem@redhat.com \
--cc=mbp@samba.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).