From: "David S. Miller" <davem@redhat.com>
To: yoshfuji@linux-ipv6.org
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com,
usagi@linux-ipv6.org, kuznet@ms2.inr.ac.ru
Subject: Re: [PATCH] IPv6: Improvement of Source Address Selection
Date: Fri, 27 Sep 2002 18:28:33 -0700 (PDT) [thread overview]
Message-ID: <20020927.182833.66704359.davem@redhat.com> (raw)
In-Reply-To: <20020928.001742.125874265.yoshfuji@linux-ipv6.org>
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>
Date: Sat, 28 Sep 2002 00:17:42 +0900 (JST)
Please redesign this structure.
+struct addrselect_attrs {
+ struct inet6_ifaddr *ifp;
+ int match;
+ int deprecated;
+ int home;
+ int temporary;
+ int device;
+ int scope;
+ int label;
+ int matchlen;
+};
This is much larger than it needs to be. Please replace these "int"
binary states with single "u32 flags;" and appropriate bit
definitions.
This structure sits on the stack, so it is important to be
as small as we can easily make it.
Otherwise I have no problems with the patch, Alexey?
next prev parent reply other threads:[~2002-09-28 1:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-27 15:17 [PATCH] IPv6: Improvement of Source Address Selection YOSHIFUJI Hideaki / 吉藤英明
2002-09-27 16:02 ` kuznet
2002-09-27 16:28 ` Pekka Savola
2002-09-27 16:55 ` kuznet
2002-09-28 1:28 ` David S. Miller [this message]
2002-09-28 2:28 ` kuznet
2002-09-28 2:34 ` Andi Kleen
2002-09-28 2:35 ` David S. Miller
2002-09-28 2:58 ` kuznet
2002-09-28 2:55 ` David S. Miller
2002-09-28 3:38 ` kuznet
2002-09-28 3:36 ` David S. Miller
2002-09-28 4:19 ` kuznet
2002-09-28 4:30 ` YOSHIFUJI Hideaki / 吉藤英明
2002-09-28 4:44 ` kuznet
2002-09-28 5:14 ` YOSHIFUJI Hideaki / 吉藤英明
2002-09-28 5:26 ` kuznet
2002-09-28 4:35 ` Pekka Savola
2002-09-28 5:00 ` kuznet
2002-09-28 5:24 ` Pekka Savola
2002-09-28 5:37 ` kuznet
2002-09-29 8:41 ` Pekka Savola
2002-10-03 16:50 ` YOSHIFUJI Hideaki / 吉藤英明
2002-10-04 6:32 ` Pekka Savola
2002-10-05 18:33 ` YOSHIFUJI Hideaki / 吉藤英明
2002-10-10 14:29 ` Pekka Savola
2002-10-10 15:23 ` YOSHIFUJI Hideaki / 吉藤英明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020927.182833.66704359.davem@redhat.com \
--to=davem@redhat.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=usagi@linux-ipv6.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).