netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: niv@us.ibm.com
Cc: netdev@oss.sgi.com
Subject: Re: [Patch 2.5.43] IpInDelivers, IpInDiscards
Date: Thu, 17 Oct 2002 15:24:52 -0700 (PDT)	[thread overview]
Message-ID: <20021017.152452.43031634.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0210171428520.3131-100000@w-nivedita.beaverton.ibm.com>


   From: Nivedita Singhvi <niv@us.ibm.com>
   Date: Thu, 17 Oct 2002 14:49:04 -0700 (PDT)

   This patch cleans up the use of the SNMP stats counters
   IpInDelivers and IpInDiscards (and the v6 counterparts). 
   A patch to address some of this had been submitted a while 
   ago by Mark Price.

I agree with with.  I just have some minor troubles with some of
the changes to ip_input.c

Specifically, the ip_rcv_finish() and ip_rcv() counter bumps
should all move to right below the drop: label which exists in
both functions.

Make this fixup, and I'll apply the patch.

Thanks.

  reply	other threads:[~2002-10-17 22:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-17 21:49 [Patch 2.5.43] IpInDelivers, IpInDiscards Nivedita Singhvi
2002-10-17 22:24 ` David S. Miller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-10-17 23:47 Nivedita Singhvi
2002-10-17 23:43 ` David S. Miller
2002-10-18  0:10   ` Nivedita Singhvi
2002-10-28 12:50     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021017.152452.43031634.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=netdev@oss.sgi.com \
    --cc=niv@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).