netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] IPv6: Fix BUG When Received Unknown Protocol
@ 2002-11-21  6:32 YOSHIFUJI Hideaki / 吉藤英明
  2002-11-22  5:56 ` David S. Miller
  0 siblings, 1 reply; 2+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2002-11-21  6:32 UTC (permalink / raw)
  To: linux-kernel, netdev; +Cc: davem, kuznet, usagi

Hi,

Since 2.5.43, kernel panics by executing BUG() when
received unknown protocol in IPv6 packet. 
This is because ip6_input_finish() try to kfree_skb() 
while icmpv6_param_prob() has already kfree_skb()'ed the skb.

Thanks.

Patch-Name: Fix BUG When Received Unknown Protocol
Patch-Author: YOSHIFUJI Hideaki / USAGI Project <yoshfuji@linux-ipv6.org>
Index: net/ipv6/ip6_input.c
===================================================================
RCS file: /cvsroot/usagi/usagi/kernel/linux25/net/ipv6/ip6_input.c,v
retrieving revision 1.1.1.3
retrieving revision 1.2
diff -u -r1.1.1.3 -r1.2
--- net/ipv6/ip6_input.c	31 Oct 2002 03:58:27 -0000	1.1.1.3
+++ net/ipv6/ip6_input.c	21 Nov 2002 05:30:59 -0000	1.2
@@ -182,9 +182,10 @@
 		if (!raw_sk) {
 			IP6_INC_STATS_BH(Ip6InUnknownProtos);
 			icmpv6_param_prob(skb, ICMPV6_UNK_NEXTHDR, nhoff);
-		} else
+		} else {
 			IP6_INC_STATS_BH(Ip6InDelivers);
-		kfree_skb(skb);
+			kfree_skb(skb);
+		}
 	}
 
 	return 0;

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] IPv6: Fix BUG When Received Unknown Protocol
  2002-11-21  6:32 [PATCH] IPv6: Fix BUG When Received Unknown Protocol YOSHIFUJI Hideaki / 吉藤英明
@ 2002-11-22  5:56 ` David S. Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2002-11-22  5:56 UTC (permalink / raw)
  To: yoshfuji; +Cc: linux-kernel, netdev, kuznet, usagi

   From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>
   Date: Thu, 21 Nov 2002 01:32:03 -0500 (EST)

   Since 2.5.43, kernel panics by executing BUG() when
   received unknown protocol in IPv6 packet. 
   This is because ip6_input_finish() try to kfree_skb() 
   while icmpv6_param_prob() has already kfree_skb()'ed the skb.

Patch applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-11-22  5:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-11-21  6:32 [PATCH] IPv6: Fix BUG When Received Unknown Protocol YOSHIFUJI Hideaki / 吉藤英明
2002-11-22  5:56 ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).