From: "David S. Miller" <davem@redhat.com>
To: srompf@isg.de
Cc: netdev@oss.sgi.com
Subject: Re: Patch resubmission: RFC2863 operstatus for 2.5.49
Date: Tue, 26 Nov 2002 02:15:46 -0800 (PST) [thread overview]
Message-ID: <20021126.021546.91313706.davem@redhat.com> (raw)
In-Reply-To: <3DE33D6D.25B9C9B4@isg.de>
This locking below achieves nothing.
+ read_lock_irqsave(&dev->operstate_lock, flags);
+ state = dev->operstate;
+ read_unlock_irqrestore(&dev->operstate_lock, flags);
In fact, the other side, locking when setting this value, can
be done with a simple spinlock. Probably something else in
the device struct can be reused.
I also don't think this should be conditional, either we want
it or we don't.
next prev parent reply other threads:[~2002-11-26 10:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-26 9:22 Patch resubmission: RFC2863 operstatus for 2.5.49 Stefan Rompf
2002-11-26 10:15 ` David S. Miller [this message]
2002-11-26 15:36 ` Stefan Rompf
2002-12-03 22:22 ` Patch resubmission: RFC2863 operstatus for 2.5.50 Stefan Rompf
2002-12-04 0:52 ` Jeff Garzik
2002-12-04 9:44 ` Stefan Rompf
2002-12-04 18:15 ` Jeff Garzik
2002-12-04 13:11 ` jamal
2002-12-04 17:42 ` Jeff Garzik
2002-12-09 13:27 ` jamal
2002-12-09 23:10 ` Stefan Rompf
2002-12-10 3:55 ` Jeff Garzik
2002-12-12 13:21 ` jamal
2002-12-04 19:39 ` David S. Miller
2002-11-29 12:56 ` Patch resubmission: RFC2863 operstatus for 2.5.49 jamal
2002-12-03 23:04 ` Stefan Rompf
2002-12-04 13:06 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021126.021546.91313706.davem@redhat.com \
--to=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=srompf@isg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).