netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J.A. Magallon" <jamagallon@able.es>
To: Andrew Morton <akpm@digeo.com>
Cc: "J.A. Magallon" <jamagallon@able.es>,
	Jeff Garzik <jgarzik@pobox.com>,
	"David S. Miller" <davem@redhat.com>,
	linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [RFC][PATCH] net drivers and cache alignment
Date: Sun, 8 Dec 2002 00:52:55 +0100	[thread overview]
Message-ID: <20021207235255.GA3754@werewolf.able.es> (raw)
In-Reply-To: <3DF28811.F6580BA6@digeo.com>; from akpm@digeo.com on Sun, Dec 08, 2002 at 00:45:21 +0100


On 2002.12.08 Andrew Morton wrote:
>"J.A. Magallon" wrote:
>> 
>> #define __cacheline_start   struct { } ____cacheline_aligned;
>
>That will generate a warning on faster^Wolder versions of gcc.
>
>mnm:/home/akpm> gcc t2.c
>t2.c:11: warning: unnamed struct/union that defines no instances
>t2.c:15: warning: unnamed struct/union that defines no instances
>mnm:/home/akpm> gcc -v 
>Reading specs from /usr/local/lib/gcc-lib/i686-pc-linux-gnu/2.95.3/specs
>gcc version 2.95.3 20010315 (release)
>

And how 'bout this (do not have any gcc oldie available to test):

#define __cacheline_start   union { int :0; } ____cacheline_aligned;

It passes gcc-3.2 -Wall...
I think it's nicer to insert __c_s than to go field by field marking
them...

-- 
J.A. Magallon <jamagallon@able.es>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.1 (Cooker) for i586
Linux 2.4.20-jam1 (gcc 3.2 (Mandrake Linux 9.1 3.2-4mdk))

  reply	other threads:[~2002-12-07 23:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-07 22:37 [RFC][PATCH] net drivers and cache alignment Jeff Garzik
2002-12-07 22:40 ` David S. Miller
2002-12-07 22:46   ` Jeff Garzik
2002-12-07 23:06   ` Jeff Garzik
2002-12-07 23:29     ` Andrew Morton
2002-12-07 23:30       ` David S. Miller
2002-12-07 23:42         ` Andrew Morton
2002-12-07 23:51           ` Andrew Morton
2002-12-15 18:31             ` Jes Sorensen
2002-12-08 20:00           ` David S. Miller
2002-12-07 23:36       ` Jeff Garzik
2002-12-07 23:37       ` J.A. Magallon
2002-12-07 23:42         ` Jeff Garzik
2002-12-07 23:45         ` Andrew Morton
2002-12-07 23:52           ` J.A. Magallon [this message]
2002-12-08  1:14       ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021207235255.GA3754@werewolf.able.es \
    --to=jamagallon@able.es \
    --cc=akpm@digeo.com \
    --cc=davem@redhat.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).