* [PATCH RESEND] memory leak in ndisc_router_discovery
@ 2002-12-12 19:05 Krishna Kumar
2002-12-16 6:35 ` YOSHIFUJI Hideaki / 吉藤英明
2002-12-21 7:08 ` David S. Miller
0 siblings, 2 replies; 3+ messages in thread
From: Krishna Kumar @ 2002-12-12 19:05 UTC (permalink / raw)
To: kuznet, davem; +Cc: netdev, linux-kernel
Hi,
I had sent this earlier, there is a bug in router advertisement handling code,
where the reference (and memory) to an inet6_dev pointer can get leaked (this
leak can happen atmost once for each interface on a system which receives
invalid RA's). Below is the patch against 2.5.51 to fix it.
thanks,
- KK
-------------------------------------------------------------------------------
diff -ruN linux.org/net/ipv6/ndisc.c linux/net/ipv6/ndisc.c
--- linux.org/net/ipv6/ndisc.c Fri Nov 7 10:02:11 2002
+++ linux/net/ipv6/ndisc.c Fri Nov 8 14:37:27 2002
@@ -871,6 +871,7 @@
}
if (!ndisc_parse_options(opt, optlen, &ndopts)) {
+ in6_dev_put(in6_dev);
if (net_ratelimit())
ND_PRINTK2(KERN_WARNING
"ICMP6 RA: invalid ND option, ignored.\n");
-------------------------------------------------------------------------------
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH RESEND] memory leak in ndisc_router_discovery
2002-12-12 19:05 [PATCH RESEND] memory leak in ndisc_router_discovery Krishna Kumar
@ 2002-12-16 6:35 ` YOSHIFUJI Hideaki / 吉藤英明
2002-12-21 7:08 ` David S. Miller
1 sibling, 0 replies; 3+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2002-12-16 6:35 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev, davem, kuznet, krkumar
In article <200212121905.gBCJ5hn18058@eng2.beaverton.ibm.com> (at Thu, 12 Dec 2002 11:05:43 -0800 (PST)), Krishna Kumar <krkumar@us.ibm.com> says:
> I had sent this earlier, there is a bug in router advertisement handling code,
> where the reference (and memory) to an inet6_dev pointer can get leaked (this
> leak can happen atmost once for each interface on a system which receives
> invalid RA's). Below is the patch against 2.5.51 to fix it.
(It would be called "refcnt leakage," or some thing like that, but anyway)
This seems correct fix. please apply...
> -------------------------------------------------------------------------------
> diff -ruN linux.org/net/ipv6/ndisc.c linux/net/ipv6/ndisc.c
> --- linux.org/net/ipv6/ndisc.c Fri Nov 7 10:02:11 2002
> +++ linux/net/ipv6/ndisc.c Fri Nov 8 14:37:27 2002
> @@ -871,6 +871,7 @@
> }
>
> if (!ndisc_parse_options(opt, optlen, &ndopts)) {
> + in6_dev_put(in6_dev);
> if (net_ratelimit())
> ND_PRINTK2(KERN_WARNING
> "ICMP6 RA: invalid ND option, ignored.\n");
> -------------------------------------------------------------------------------
--
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH RESEND] memory leak in ndisc_router_discovery
2002-12-12 19:05 [PATCH RESEND] memory leak in ndisc_router_discovery Krishna Kumar
2002-12-16 6:35 ` YOSHIFUJI Hideaki / 吉藤英明
@ 2002-12-21 7:08 ` David S. Miller
1 sibling, 0 replies; 3+ messages in thread
From: David S. Miller @ 2002-12-21 7:08 UTC (permalink / raw)
To: krkumar; +Cc: kuznet, netdev, linux-kernel
From: Krishna Kumar <krkumar@us.ibm.com>
Date: Thu, 12 Dec 2002 11:05:43 -0800 (PST)
I had sent this earlier, there is a bug in router advertisement handling code,
where the reference (and memory) to an inet6_dev pointer can get leaked (this
leak can happen atmost once for each interface on a system which receives
invalid RA's). Below is the patch against 2.5.51 to fix it.
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-12-21 7:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-12-12 19:05 [PATCH RESEND] memory leak in ndisc_router_discovery Krishna Kumar
2002-12-16 6:35 ` YOSHIFUJI Hideaki / 吉藤英明
2002-12-21 7:08 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).