From: "David S. Miller" <davem@redhat.com>
To: bcrl@redhat.com
Cc: netdev@oss.sgi.com
Subject: Re: [patch/bk] remove scm_cookie parameter to send/recvmsg
Date: Mon, 20 Jan 2003 21:14:16 -0800 (PST) [thread overview]
Message-ID: <20030120.211416.98847188.davem@redhat.com> (raw)
In-Reply-To: <20030120161755.B23890@redhat.com>
From: Benjamin LaHaise <bcrl@redhat.com>
Date: Mon, 20 Jan 2003 16:17:55 -0500
+ memset(&scm, 0, sizeof(scm));
init_sync_kiocb(&iocb, NULL);
si = kiocb_to_siocb(&iocb);
si->sock = sock;
- si->scm = &si->async_scm;
+ si->scm = &scm;
si->msg = &kern_msg;
si->size = total_len;
si->flags = user_flags;
memset(si->scm, 0, sizeof(*si->scm));
We're now memset()'ing it twice? :) I think the first
memset isn't needed, and this makes the code consistent with
the other places this logic is duplicated.
Otherwise the patch is fine, please fix this stuff up and
resubmit, thanks.
prev parent reply other threads:[~2003-01-21 5:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-20 21:17 [patch/bk] remove scm_cookie parameter to send/recvmsg Benjamin LaHaise
2003-01-21 5:14 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030120.211416.98847188.davem@redhat.com \
--to=davem@redhat.com \
--cc=bcrl@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).