From: Jeff Garzik <jgarzik@pobox.com>
To: "Patrick R. McManus" <mcmanus@ducksong.com>
Cc: netdev@oss.sgi.com
Subject: Re: SIOCETHTOOL ioctl() and a corrupted cmd argument
Date: Wed, 5 Mar 2003 16:41:55 -0500 [thread overview]
Message-ID: <20030305214155.GM13420@gtf.org> (raw)
In-Reply-To: <20030305213205.GA1227@ducksong.com>
On Wed, Mar 05, 2003 at 04:32:05PM -0500, Patrick R. McManus wrote:
> but SIOCETHTOOL shouldn't need perms, right? it has some functionality
> that needs it and some that doesn't, and the driver sorts it
> out.. there isn't a GIOCETHTOOL at all..
>
> #define ETHTOOL_GSET 0x00000001 /* Get settings. */
> #define ETHTOOL_SSET 0x00000002 /* Set settings, privileged. */
You are correct that comment is misleading... all ethtool does current
requiring CAP_NET_ADMIN. This is one of the costs of lumping things
under one ioctl, rather than constantly using new ioctls.
It is certainly possible (and reasonable) that a future kernel peeks at
the ioctl and then conditionally checks privs, but this is not currently
the case.
Jeff
prev parent reply other threads:[~2003-03-05 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-05 21:00 SIOCETHTOOL ioctl() and a corrupted cmd argument Patrick R. McManus
2003-03-05 21:32 ` Patrick R. McManus
2003-03-05 21:41 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030305214155.GM13420@gtf.org \
--to=jgarzik@pobox.com \
--cc=mcmanus@ducksong.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).