From: "David S. Miller" <davem@redhat.com>
To: jgrimm2@us.ibm.com
Cc: linux-net@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [PATCH] Fix ip6_build_xmit bug
Date: Sun, 23 Mar 2003 01:22:29 -0800 (PST) [thread overview]
Message-ID: <20030323.012229.36386243.davem@redhat.com> (raw)
In-Reply-To: <3E7BAC7E.AEC59251@us.ibm.com>
From: Jon Grimm <jgrimm2@us.ibm.com>
Date: Fri, 21 Mar 2003 18:21:18 -0600
Looks like ip6_build_xmit does not allocate room for the
dev->hard_header_len on the non-fragmentation path as is done in other
places. The hard header len gets reserved even though room was not
allocated for it. Consequenetly, the put of the raw data can overflow
the skb.
Patch below for your consideration.
Applied, but with a minor fix. We now have a LL_RESERVED_SPACE(dev)
macro in include/linux/netdevice.h that gets this formula correct
and thus I have used it.
Thanks.
And yes we do know things are still slightly broken with ipv6
fragmentation wrt. IPSEC, and that is being actively worked on.
The IPV4 output path hacks just need to be duplicated into ipv6
before that will start working reliably.
prev parent reply other threads:[~2003-03-23 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-22 0:21 [PATCH] Fix ip6_build_xmit bug Jon Grimm
2003-03-22 19:26 ` ip6sec MTU/fragmentation issue / Was: " bert hubert
2003-03-23 9:22 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030323.012229.36386243.davem@redhat.com \
--to=davem@redhat.com \
--cc=jgrimm2@us.ibm.com \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).