From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David S. Miller" Subject: Re: BUG or not? GFP_KERNEL with interrupts disabled. Date: Thu, 27 Mar 2003 06:12:41 -0800 (PST) Sender: netdev-bounce@oss.sgi.com Message-ID: <20030327.061241.105170741.davem@redhat.com> References: <20030327.054357.17283294.davem@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: shmulik.hen@intel.com, dane@aiinet.com, bonding-devel@lists.sourceforge.net, bonding-announce@lists.sourceforge.net, netdev@oss.sgi.com, linux-kernel@vger.kernel.org, linux-net@vger.kernel.org, torvalds@transmeta.com, mingo@redhat.com, kuznet@ms2.inr.ac.ru Return-path: To: trond.myklebust@fys.uio.no In-Reply-To: Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org From: Trond Myklebust Date: 27 Mar 2003 15:11:56 +0100 > IRQ disabling is meant to be stronger than softint disabling. In that case, you'll need to have things like spin_lock_irqrestore() call local_bh_enable() in order to run the pending softirqs. Is that worth the trouble? "trouble" is a weird word to use when the current behavior is just wrong. :-) My point is that it doesn't matter what the fix is, running softints while hw IRQs are disabled must be fixed.