From: "David S. Miller" <davem@redhat.com>
To: torvalds@transmeta.com
Cc: dane@aiinet.com, shmulik.hen@intel.com,
bonding-devel@lists.sourceforge.net,
bonding-announce@lists.sourceforge.net, netdev@oss.sgi.com,
linux-kernel@vger.kernel.org, linux-net@vger.kernel.org,
mingo@redhat.com, kuznet@ms2.inr.ac.ru
Subject: Re: BUG or not? GFP_KERNEL with interrupts disabled.
Date: Thu, 27 Mar 2003 13:29:54 -0800 (PST) [thread overview]
Message-ID: <20030327.132954.96279785.davem@redhat.com> (raw)
In-Reply-To: <20030327.125507.104718048.davem@redhat.com>
From: "David S. Miller" <davem@redhat.com>
Date: Thu, 27 Mar 2003 12:55:07 -0800 (PST)
Alexey has pointed out a bug in my changes.
@@ -1088,6 +1086,9 @@ void smp_percpu_timer_interrupt(struct p
: /* no outputs */
: "r" (pstate));
} while (time_after_eq(tick, compare));
+
+ local_irq_enable();
+ irq_exit();
}
static void __init smp_setup_percpu_timer(void)
Of course this is bogus.
The IRQ enable needs to occur in the irq_exit() branch right
before do_softirq() is invoked.
next prev parent reply other threads:[~2003-03-27 21:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3B785392832ED71192AE00D0B7B0D75B539668@aimail.aiinet.com>
2003-03-27 19:02 ` BUG or not? GFP_KERNEL with interrupts disabled Dan Eble
2003-03-27 19:08 ` Linus Torvalds
2003-03-27 19:10 ` David S. Miller
2003-03-27 19:22 ` Linus Torvalds
2003-03-27 19:39 ` David S. Miller
2003-03-27 19:52 ` Robert Love
2003-03-27 19:53 ` David S. Miller
2003-03-27 20:55 ` David S. Miller
2003-03-27 21:29 ` David S. Miller [this message]
[not found] <E791C176A6139242A988ABA8B3D9B38A01085638@hasmsx403.iil.intel.com>
2003-03-27 13:32 ` shmulik.hen
2003-03-27 13:43 ` David S. Miller
2003-03-27 14:11 ` Trond Myklebust
2003-03-27 14:12 ` David S. Miller
2003-03-27 17:22 ` Linus Torvalds
2003-03-27 17:55 ` David S. Miller
2003-03-27 18:04 ` Linus Torvalds
2003-03-27 18:07 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030327.132954.96279785.davem@redhat.com \
--to=davem@redhat.com \
--cc=bonding-announce@lists.sourceforge.net \
--cc=bonding-devel@lists.sourceforge.net \
--cc=dane@aiinet.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=shmulik.hen@intel.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).