From: "David S. Miller" <davem@redhat.com>
To: yoshfuji@linux-ipv6.org
Cc: toml@us.ibm.com, netdev@oss.sgi.com, kuznet@ms2.inr.ac.ru
Subject: Re: [PATCH] IPSec: Use of "sizeof" for header sizes, part II
Date: Tue, 01 Apr 2003 19:34:29 -0800 (PST) [thread overview]
Message-ID: <20030401.193429.64279267.davem@redhat.com> (raw)
In-Reply-To: <20030402.122518.62753078.yoshfuji@linux-ipv6.org>
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>
Date: Wed, 02 Apr 2003 12:25:18 +0900 (JST)
In article <20030401.140727.73666851.davem@redhat.com> (at Tue, 01 Apr 2003 14:07:27 -0800 (PST)), "David S. Miller" <davem@redhat.com> says:
> From: Tom Lendacky <toml@us.ibm.com>
> Date: 01 Apr 2003 16:04:32 -0600
>
> Please review and let me know if any changes are required.
>
> Ok, now that I look at this I realize my suggestions from the other
> day were wrong.
>
> These expressions are huge, it's almost less readable. Let's compact
> this, by creating a struct named {ip,ipv6}_esp_header_no_enc_data.
How about just removing 8 bytes from struct {ip,ipv6}_esp_hdr
like this?
Sure, but does anyone need the 8 bytes there? I thought so, which is
why I didn't think about your suggestion :-)
next prev parent reply other threads:[~2003-04-02 3:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-01 22:04 [PATCH] IPSec: Use of "sizeof" for header sizes, part II Tom Lendacky
2003-04-01 22:07 ` David S. Miller
2003-04-02 3:25 ` YOSHIFUJI Hideaki / 吉藤英明
2003-04-02 3:34 ` David S. Miller [this message]
2003-04-02 4:02 ` YOSHIFUJI Hideaki / 吉藤英明
2003-04-02 4:02 ` David S. Miller
2003-04-02 4:20 ` YOSHIFUJI Hideaki / 吉藤英明
-- strict thread matches above, loose matches on Subject: below --
2003-04-02 15:00 Tom Lendacky
2003-04-03 4:51 ` YOSHIFUJI Hideaki / 吉藤英明
2003-04-03 12:20 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030401.193429.64279267.davem@redhat.com \
--to=davem@redhat.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@oss.sgi.com \
--cc=toml@us.ibm.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).