From: Jeff Garzik <jgarzik@pobox.com>
To: "Feldman, Scott" <scott.feldman@intel.com>
Cc: Robert Olsson <Robert.Olsson@data.slu.se>,
Jason Lunz <lunz@falooley.org>,
netdev@oss.sgi.com
Subject: Re: [Fwd: [E1000] NAPI re-insertion w/ changes]
Date: Tue, 1 Apr 2003 16:16:51 -0500 [thread overview]
Message-ID: <20030401211651.GA23739@gtf.org> (raw)
In-Reply-To: <C6F5CF431189FA4CBAEC9E7DD5441E010107D30D@orsmsx402.jf.intel.com>
On Tue, Apr 01, 2003 at 09:47:55AM -0800, Feldman, Scott wrote:
> > A better approximation I think but probably not the last...
>
> Thanks for you help guys! I broke NAPI (don't hate me) and then went on
> vacation, so I apologize for not responding sooner. I like what you've
> come up with here, so I'll turn the patch around for Jeff to update 2.5
> e1000.
>
> > + e1000_clean_tx_irq(adapter);
> > + e1000_clean_rx_irq(adapter, &work_done, work_to_do);
>
> Just curious, why give priority to Tx over Rx?
TX frees skbs, RX allocates skbs.
You lessen the chance of allocation failure or "additional work" being
performed by the allocator when you do it in this order.
Jeff
next prev parent reply other threads:[~2003-04-01 21:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-01 17:47 [Fwd: [E1000] NAPI re-insertion w/ changes] Feldman, Scott
2003-04-01 18:57 ` Robert Olsson
2003-04-01 21:16 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-04-02 0:13 Feldman, Scott
2003-04-02 4:19 ` Jason Lunz
2003-04-01 21:22 Feldman, Scott
2003-04-01 19:13 Feldman, Scott
2003-04-01 19:23 ` Jason Lunz
2003-04-01 22:40 ` Jason Lunz
2003-04-01 19:44 ` Robert Olsson
2003-03-27 16:54 Robert Olsson
2003-03-27 17:10 ` Jason Lunz
2003-03-28 8:27 ` Robert Olsson
2003-03-28 17:32 ` Jason Lunz
2003-03-28 18:43 ` Robert Olsson
2003-03-22 18:47 Feldman, Scott
2003-03-22 20:28 ` Robert Olsson
2003-03-31 17:14 ` Robert Olsson
2003-03-21 14:46 Jeff Garzik
2003-03-22 15:34 ` Robert Olsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030401211651.GA23739@gtf.org \
--to=jgarzik@pobox.com \
--cc=Robert.Olsson@data.slu.se \
--cc=lunz@falooley.org \
--cc=netdev@oss.sgi.com \
--cc=scott.feldman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).