* snmp stats as %ld or %lu @ 2003-04-02 12:27 Randy.Dunlap 2003-04-03 12:48 ` David S. Miller 0 siblings, 1 reply; 4+ messages in thread From: Randy.Dunlap @ 2003-04-02 12:27 UTC (permalink / raw) To: linux-net; +Cc: netdev Hi, ipv4/proc.c prints SNMP stats using %lu, but ipv6/proc.c prints them using %ld. Is this difference intentional, planned, or an oversight, or something else? Thanks, -- ~Randy ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: snmp stats as %ld or %lu 2003-04-02 12:27 snmp stats as %ld or %lu Randy.Dunlap @ 2003-04-03 12:48 ` David S. Miller 2003-04-03 8:02 ` [PATCH] snmp6 stats as %lu Randy.Dunlap 0 siblings, 1 reply; 4+ messages in thread From: David S. Miller @ 2003-04-03 12:48 UTC (permalink / raw) To: rddunlap; +Cc: linux-net, netdev From: "Randy.Dunlap" <rddunlap@osdl.org> Date: Wed, 2 Apr 2003 12:27:55 +0000 ipv4/proc.c prints SNMP stats using %lu, but ipv6/proc.c prints them using %ld. Is this difference intentional, planned, or an oversight, or something else? Looks like an oversight to me, both should use the unsigned format. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] snmp6 stats as %lu 2003-04-03 12:48 ` David S. Miller @ 2003-04-03 8:02 ` Randy.Dunlap 2003-04-03 16:11 ` David S. Miller 0 siblings, 1 reply; 4+ messages in thread From: Randy.Dunlap @ 2003-04-03 8:02 UTC (permalink / raw) To: David S. Miller; +Cc: linux-net, netdev On Thu, 03 Apr 2003 04:48:22 -0800 (PST) "David S. Miller" <davem@redhat.com> wrote: | From: "Randy.Dunlap" <rddunlap@osdl.org> | Date: Wed, 2 Apr 2003 12:27:55 +0000 | | ipv4/proc.c prints SNMP stats using %lu, | but ipv6/proc.c prints them using %ld. | | Is this difference intentional, planned, or an oversight, | or something else? | | Looks like an oversight to me, both should use the unsigned format. Here's the patch, on top of the seq_file conversion. Thanks, -- ~Randy patch_name: snmp6-ulong.patch patch_version: 2003-04-03.07:57:48 author: Randy.Dunlap <rddunlap@osdl.org> description: modify /proc/net/snmp6 to use %lu instead of %ld for output product: Linux product_versions: 2.5.66 maintainer: Dave Miller (davem@redhat.com) diffstat: = net/ipv6/proc.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -Naur ./net/ipv6/proc.c%SN6ULF ./net/ipv6/proc.c --- ./net/ipv6/proc.c%SN6ULF Thu Apr 3 07:56:44 2003 +++ ./net/ipv6/proc.c Thu Apr 3 07:57:07 2003 @@ -156,7 +156,7 @@ int i; for (i=0; i<sizeof(snmp6_list)/sizeof(snmp6_list[0]); i++) - seq_printf(seq, "%-32s\t%ld\n", snmp6_list[i].name, + seq_printf(seq, "%-32s\t%lu\n", snmp6_list[i].name, fold_field(snmp6_list[i].mib, snmp6_list[i].offset)); return 0; ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] snmp6 stats as %lu 2003-04-03 8:02 ` [PATCH] snmp6 stats as %lu Randy.Dunlap @ 2003-04-03 16:11 ` David S. Miller 0 siblings, 0 replies; 4+ messages in thread From: David S. Miller @ 2003-04-03 16:11 UTC (permalink / raw) To: rddunlap; +Cc: linux-net, netdev From: "Randy.Dunlap" <rddunlap@osdl.org> Date: Thu, 3 Apr 2003 08:02:44 +0000 On Thu, 03 Apr 2003 04:48:22 -0800 (PST) "David S. Miller" <davem@redhat.com> wrote: | Looks like an oversight to me, both should use the unsigned format. Here's the patch, on top of the seq_file conversion. Applied, thanks Randy. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-04-03 16:11 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2003-04-02 12:27 snmp stats as %ld or %lu Randy.Dunlap 2003-04-03 12:48 ` David S. Miller 2003-04-03 8:02 ` [PATCH] snmp6 stats as %lu Randy.Dunlap 2003-04-03 16:11 ` David S. Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).