netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: "David S. Miller" <davem@redhat.com>
Cc: linux-net@vger.kernel.org, netdev@oss.sgi.com
Subject: [PATCH] snmp6 stats as %lu
Date: Thu, 3 Apr 2003 08:02:44 +0000	[thread overview]
Message-ID: <20030403080244.6bb772e3.rddunlap@osdl.org> (raw)
In-Reply-To: <20030403.044822.00469453.davem@redhat.com>

On Thu, 03 Apr 2003 04:48:22 -0800 (PST) "David S. Miller" <davem@redhat.com> wrote:

|    From: "Randy.Dunlap" <rddunlap@osdl.org>
|    Date: Wed, 2 Apr 2003 12:27:55 +0000
| 
|    ipv4/proc.c prints SNMP stats using %lu,
|    but ipv6/proc.c prints them using %ld.
|    
|    Is this difference intentional, planned, or an oversight,
|    or something else?
| 
| Looks like an oversight to me, both should use the unsigned format.

Here's the patch, on top of the seq_file conversion.

Thanks,
--
~Randy


patch_name:	snmp6-ulong.patch
patch_version:	2003-04-03.07:57:48
author:		Randy.Dunlap <rddunlap@osdl.org>
description:	modify /proc/net/snmp6 to use %lu instead of %ld for output
product:	Linux
product_versions: 2.5.66
maintainer:	Dave Miller (davem@redhat.com)
diffstat:	=
 net/ipv6/proc.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)


diff -Naur ./net/ipv6/proc.c%SN6ULF ./net/ipv6/proc.c
--- ./net/ipv6/proc.c%SN6ULF	Thu Apr  3 07:56:44 2003
+++ ./net/ipv6/proc.c	Thu Apr  3 07:57:07 2003
@@ -156,7 +156,7 @@
 	int i;
 
 	for (i=0; i<sizeof(snmp6_list)/sizeof(snmp6_list[0]); i++)
-		seq_printf(seq, "%-32s\t%ld\n", snmp6_list[i].name,
+		seq_printf(seq, "%-32s\t%lu\n", snmp6_list[i].name,
 			       fold_field(snmp6_list[i].mib, snmp6_list[i].offset));
 
 	return 0;

  reply	other threads:[~2003-04-03  8:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-02 12:27 snmp stats as %ld or %lu Randy.Dunlap
2003-04-03 12:48 ` David S. Miller
2003-04-03  8:02   ` Randy.Dunlap [this message]
2003-04-03 16:11     ` [PATCH] snmp6 stats as %lu David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030403080244.6bb772e3.rddunlap@osdl.org \
    --to=rddunlap@osdl.org \
    --cc=davem@redhat.com \
    --cc=linux-net@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).