From: "David S. Miller" <davem@redhat.com>
To: akpm@digeo.com
Cc: netdev@oss.sgi.com
Subject: Re: [2.5.66-mm3+debug] traces.
Date: Fri, 04 Apr 2003 17:35:38 -0800 (PST) [thread overview]
Message-ID: <20030404.173538.03688224.davem@redhat.com> (raw)
In-Reply-To: <20030404172927.2b449167.akpm@digeo.com>
From: Andrew Morton <akpm@digeo.com>
Date: Fri, 4 Apr 2003 17:29:27 -0800
It is a bit worrisome that dev_kfree_skb() is now illegal if local interrupts
are disabled. I'd expect there to be more instances.
Why worrisome? It's an error, and now at least we'll know
about it. This isn't a "is now illegal", it's always been
illegal. You simply cannot take BH locks inside of IRQ disabling
ones, this is true 2.4.x too it just doesn't BUG() on you there
(you get a potential deadlock instead).
This patch should go through the Tulip maintainer (Jeff I guess)
especially since it's a fix that belongs in 2.4.x as well.
Thanks Andrew.
next prev parent reply other threads:[~2003-04-05 1:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-05 1:29 Fw: [2.5.66-mm3+debug] traces Andrew Morton
2003-04-05 1:35 ` David S. Miller [this message]
2003-04-05 2:14 ` Andrew Morton
2003-04-05 2:27 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030404.173538.03688224.davem@redhat.com \
--to=davem@redhat.com \
--cc=akpm@digeo.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).