From: "David S. Miller" <davem@redhat.com>
To: akpm@digeo.com
Cc: netdev@oss.sgi.com
Subject: Re: [2.5.66-mm3+debug] traces.
Date: Fri, 04 Apr 2003 18:27:16 -0800 (PST) [thread overview]
Message-ID: <20030404.182716.06393733.davem@redhat.com> (raw)
In-Reply-To: <20030404181427.5cf0c127.akpm@digeo.com>
From: Andrew Morton <akpm@digeo.com>
Date: Fri, 4 Apr 2003 18:14:27 -0800
"David S. Miller" <davem@redhat.com> wrote:
>
> You simply cannot take BH locks inside of IRQ disabling
> ones, this is true 2.4.x too it just doesn't BUG() on you there
> (you get a potential deadlock instead).
I don't recall seeing a description or discussion of this deadlock.
Any pointers?
Search the archives for the subject "BUG or not? GFP_KERNEL with
interrupts disabled." unfortunately it appears a lot of that
thread got privatized and I don't have any logs.
The long and short of it is:
spin_lock_irq();
anything which does local_bh_{enable,disable}()
spin_unlock_irq();
and similar are illegal.
local_bh_enable() invokes do_softirq() if softints are pending,
do_softirq() enables cpu interrupts, which would result in a deadlock
in the above case (because an interrupt could arrive and try to take
the IRQ spinlock taken by spin_lock_irq()).
Therefore it's a bug, and it's a bug everywhere BUG() check or not. :-)
prev parent reply other threads:[~2003-04-05 2:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-05 1:29 Fw: [2.5.66-mm3+debug] traces Andrew Morton
2003-04-05 1:35 ` David S. Miller
2003-04-05 2:14 ` Andrew Morton
2003-04-05 2:27 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030404.182716.06393733.davem@redhat.com \
--to=davem@redhat.com \
--cc=akpm@digeo.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).