netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: yoshfuji@linux-ipv6.org
Cc: kuznet@ms2.inr.ac.ru, netdev@oss.sgi.com, usagi@linux-ipv6.org
Subject: Re: MOD_{INC,SEC}_USE_COUNT() in net/ipv{4,6}
Date: Wed, 09 Apr 2003 18:00:04 -0700 (PDT)	[thread overview]
Message-ID: <20030409.180004.08009488.davem@redhat.com> (raw)
In-Reply-To: <20030409.204157.51648508.yoshfuji@linux-ipv6.org>

   From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>
   Date: Wed, 09 Apr 2003 20:41:57 +0900 (JST)

   This patch (against 2.5.67) converts MOD_{INC,DEC}_USE_COUNT in 
   net/ipv{4,6} to try_module_get() and module_put().

Applied, but let's recognize that ipv6 is totally broken
in this area.

The try_module_get()'s, in order to work, would need to happen
at a higher layer (socket ops or similar).  But even this is
broken, module unloading of ipv6 needs to be done via some kind
of callback scheme, the simple counter mechanism that modules
use now is inappropriate for things like ipv6 which already keeps
track of it's own references internally and only it knows how to
interlock properly to cleanly check for module references and to
shut down the whole module.

  reply	other threads:[~2003-04-10  1:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-09 11:41 MOD_{INC,SEC}_USE_COUNT() in net/ipv{4,6} YOSHIFUJI Hideaki / 吉藤英明
2003-04-10  1:00 ` David S. Miller [this message]
2003-04-10  2:54   ` kuznet
2003-04-10  6:29     ` David S. Miller
2003-04-10 19:11       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030409.180004.08009488.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@oss.sgi.com \
    --cc=usagi@linux-ipv6.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).