From: "David S. Miller" <davem@redhat.com>
To: yoshfuji@linux-ipv6.org
Cc: kuznet@ms2.inr.ac.ru, netdev@oss.sgi.com, usagi@linux-ipv6.org
Subject: Re: [PATCH] [NET] use fl6_{src,dst} etc.
Date: Mon, 14 Apr 2003 10:31:43 -0700 (PDT) [thread overview]
Message-ID: <20030414.103143.64788453.davem@redhat.com> (raw)
In-Reply-To: <20030415.023158.36869337.yoshfuji@linux-ipv6.org>
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>
Date: Tue, 15 Apr 2003 02:31:58 +0900 (JST)
I think this idea needs a slight modification:
+#define fl_sport uli_u.ports.sport
+#define fl_dport uli_u.ports.dport
+#define fl_type uli_u.icmpt.type
+#define fl_code uli_u.icmpt.code
Other protocols like DecNET will use these areas, and I already know
that DecNET defines it's own struct member of the flow uli_u union
that itself has members named sport and dport.
How about the following instead?
+#define fl_ports_sport uli_u.ports.sport
+#define fl_ports_dport uli_u.ports.dport
+#define fl_icmp_type uli_u.icmpt.type
+#define fl_icmp_code uli_u.icmpt.code
Ok?
next prev parent reply other threads:[~2003-04-14 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-14 17:31 [PATCH] [NET] use fl6_{src,dst} etc YOSHIFUJI Hideaki / 吉藤英明
2003-04-14 17:31 ` David S. Miller [this message]
2003-04-14 17:52 ` YOSHIFUJI Hideaki / 吉藤英明
2003-04-14 17:48 ` David S. Miller
2003-04-15 2:58 ` YOSHIFUJI Hideaki / 吉藤英明
2003-04-16 17:49 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030414.103143.64788453.davem@redhat.com \
--to=davem@redhat.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@oss.sgi.com \
--cc=usagi@linux-ipv6.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).