From: "David S. Miller" <davem@redhat.com>
To: kazunori@miyazawa.org
Cc: kuznet@ms2.inr.ac.ru, netdev@oss.sgi.com, usagi@linux-ipv6.org
Subject: Re: [PACTH][IPV6] Introduce ip6_append_data
Date: Wed, 16 Apr 2003 21:03:06 -0700 (PDT) [thread overview]
Message-ID: <20030416.210306.110472553.davem@redhat.com> (raw)
In-Reply-To: <20030417130231.179c7f00.kazunori@miyazawa.org>
You take direct page_address() of page, this is in general illegal.
Generally you must kmap the page to access it in the kernel as it may
be a HIGHMEM page.
I know that right now you control all the allocations with
alloc_page() and sk->allocation cannot currently allow highmem pages,
but let us not start with the assumptions right now :-)
As soon as you write udp6_sendfile() you will need to handle
this, that is for sure.
prev parent reply other threads:[~2003-04-17 4:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-17 4:02 [PACTH][IPV6] Introduce ip6_append_data Kazunori Miyazawa
2003-04-17 4:03 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030416.210306.110472553.davem@redhat.com \
--to=davem@redhat.com \
--cc=kazunori@miyazawa.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@oss.sgi.com \
--cc=usagi@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).