From mboxrd@z Thu Jan 1 00:00:00 1970 From: jamal Subject: Re: [PATCH] qdisc oops fix Date: Thu, 17 Apr 2003 06:55:19 -0400 (EDT) Sender: netdev-bounce@oss.sgi.com Message-ID: <20030417065352.S6710@shell.cyberus.ca> References: <20030415084706.O1131@shell.cyberus.ca> <20030416072952.E4013@shell.cyberus.ca> <3E9D755A.8060601@colorfullife.com> <20030416142802.E5912@shell.cyberus.ca> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Manfred Spraul , Tomas Szepe , "" , "" , "" Return-path: To: Catalin BOIE In-Reply-To: Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org Ok, I stand corrected. Tomas is right- same problem. You had htb loaded as a module, the other person had it compiled in ;-> Get yourself upgraded ;-> cheers, jamal On Thu, 17 Apr 2003, Catalin BOIE wrote: > > Catalin, Can you what kernel that is? > > 2.4.20pre10 works ok but 2.4.20 crash. > With traffic -> no crash with 2.4.20. Without traffic, on other machine, > no crash. > > > > > It's triggered, because someone does something like > > > spin_lock_bh(&my_lock); > > > p = kmalloc(,GFP_KERNEL); > > > > > > I don't like the proposed fix: usually code that calls > > > kmalloc(,GFP_KERNEL) assumes that it runs at process space, e.g. uses > > > semaphores, or non-bh spinlocks, etc. > > > slab just happens to contain a test that complains about illegal calls. > > > > ok. Nice. > > > > > > > > >>Trace; c0127e0f > > > >>Trace; c01d3cac > > > >>Trace; d081ecc7 > > > >>Trace; c01d5265 > > > >>Trace; d0820600 > > > >>Trace; c01d27e4 > > > >>Trace; c01d0605 <__neigh_event_send+89/1b4> > > > >>Trace; c01d7cd4 > > > >>Trace; c01d7730 > > > >>Trace; c01d7b73 > > > >>Trace; c01c79d5 > > > >>Trace; c01c8b48 > > > >>Trace; c0120010 > > > >> > > > >> > > > >> > > > >> > > > I don't understand the backtrace. Were any modules loaded? Perhaps > > > 0xd081ecc7 is a module. > > > > > > > Probably a module. Again Catalin, run no modules. > It's a production machine. I cannot test this. We plan to replace the > machine, so I can test then. > > > > I'd add a > > > if(in_interrupt()) show_stack(NULL); > > > into qdisc_create_dflt(), and try to reproduce the bug without modules. > > > > > > > Catalin - again instead of your fix can you please add this call? > See above. I cannot test now. I'm very sorry! > > > cheers, > > jamal > > > > --- > Catalin(ux) BOIE > catab@deuroconsult.ro > >