* ip_gre.c:ipgre_tunnel_xmit() duplicated code ?
[not found] <20030418.034241.38698733.davem@redhat.com>
@ 2003-04-21 10:21 ` Steven Whitehouse
2003-04-22 6:43 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Steven Whitehouse @ 2003-04-21 10:21 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
Hi,
I found some code in ip_gre.c which looks to be duplicated. Is the attached
the right fix or did I miss something?
Steve.
-----------------------------------------------------------------------------
diff -Nru linux-2.5.68/net/ipv4/ip_gre.c linux/net/ipv4/ip_gre.c
--- linux-2.5.68/net/ipv4/ip_gre.c Sun Apr 20 03:28:01 2003
+++ linux/net/ipv4/ip_gre.c Mon Apr 21 03:05:23 2003
@@ -777,9 +777,6 @@
skb->dst->ops->update_pmtu(skb->dst, mtu);
if (skb->protocol == htons(ETH_P_IP)) {
- if (skb->dst)
- skb->dst->ops->update_pmtu(skb->dst, mtu);
-
df |= (old_iph->frag_off&htons(IP_DF));
if ((old_iph->frag_off&htons(IP_DF)) &&
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ip_gre.c:ipgre_tunnel_xmit() duplicated code ?
2003-04-21 10:21 ` ip_gre.c:ipgre_tunnel_xmit() duplicated code ? Steven Whitehouse
@ 2003-04-22 6:43 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2003-04-22 6:43 UTC (permalink / raw)
To: Steve, steve; +Cc: netdev
From: Steven Whitehouse <steve@gw.chygwyn.com>
Date: Mon, 21 Apr 2003 11:21:59 +0100 (BST)
I found some code in ip_gre.c which looks to be duplicated. Is the
attached the right fix or did I miss something?
You're right, I've integrated your fix thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-04-22 6:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20030418.034241.38698733.davem@redhat.com>
2003-04-21 10:21 ` ip_gre.c:ipgre_tunnel_xmit() duplicated code ? Steven Whitehouse
2003-04-22 6:43 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).