From: Andi Kleen <ak@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: davem@redhat.com, netdev@oss.sgi.com
Subject: Re: purpose of the skb head pool
Date: Tue, 29 Apr 2003 15:03:17 +0200 [thread overview]
Message-ID: <20030429130317.GA32212@Wotan.suse.de> (raw)
In-Reply-To: <20030429135506.A22411@lst.de>
On Tue, Apr 29, 2003 at 01:55:06PM +0200, Christoph Hellwig wrote:
> [sorry, wrong Cc: the first time]
>
> net/core/skbuf.c has a small per-cpu pool to keep some hot skbufs around
> instead of returning them to the system allocator. But if you loook
> at the slab allocator we'll have exactly that same code duplicated in
> there (see functions ac_data, __cache_alloc and kmem_cache_alloc in
> slab.c). So is there some other reason why this pool is needed?
The code was added before slab grew an own per cpu allocator.
AFAIK it wasn't removed because the "extreme routing" people
like Jamal and Robert O. still saw small advantages, but it's
probably worth rebenchmarking.
-Andi
next prev parent reply other threads:[~2003-04-29 13:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-29 11:55 purpose of the skb head pool Christoph Hellwig
2003-04-29 13:03 ` Andi Kleen [this message]
2003-04-29 13:11 ` Robert Olsson
2003-04-29 13:08 ` David S. Miller
2003-04-29 14:16 ` Christoph Hellwig
2003-04-29 13:12 ` David S. Miller
2003-04-29 14:21 ` Christoph Hellwig
2003-04-30 5:39 ` David S. Miller
2003-04-29 13:05 ` Robert Olsson
2003-05-01 10:38 ` Florian Weimer
2003-05-01 9:35 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030429130317.GA32212@Wotan.suse.de \
--to=ak@suse.de \
--cc=davem@redhat.com \
--cc=hch@lst.de \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).